Bug 71338 - Remove initErrorEvent method
Summary: Remove initErrorEvent method
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominic Cooney
URL:
Keywords:
Depends on:
Blocks: 68791
  Show dependency treegraph
 
Reported: 2011-11-01 16:40 PDT by Dominic Cooney
Modified: 2011-11-01 18:21 PDT (History)
4 users (show)

See Also:


Attachments
Patch (7.17 KB, patch)
2011-11-01 17:08 PDT, Dominic Cooney
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Cooney 2011-11-01 16:40:21 PDT
Nobody uses this, so we should un-ship it.
Comment 1 Dominic Cooney 2011-11-01 17:08:04 PDT
Created attachment 113260 [details]
Patch
Comment 2 Ojan Vafai 2011-11-01 17:14:52 PDT
Comment on attachment 113260 [details]
Patch

Kill all the inits!
Comment 3 Darin Adler 2011-11-01 17:15:34 PDT
(In reply to comment #0)
> Nobody uses this, so we should un-ship it.

How do we know nobody uses it?
Comment 4 Ojan Vafai 2011-11-01 17:20:12 PDT
(In reply to comment #3)
> (In reply to comment #0)
> > Nobody uses this, so we should un-ship it.
> 
> How do we know nobody uses it?

We don't know it definitively, but the init*event methods other than for mouse and key events are rarely used and they are being removed from the specs. I think there's a very low risk of sites depending on this.
Comment 5 Dominic Cooney 2011-11-01 17:23:14 PDT
(In reply to comment #3)
> How do we know nobody uses it?

We think nobody uses it, because this search has no results: <http://codesearch.google.com/#search/&q=initErrorEvent%20lang:js&type=cs> And manually inspecting this broader set of search results didn't turn up any uses: <http://codesearch.google.com/#search/&q=initErrorEvent> Naturally this is not a 100% robust method for determining whether it is used.
Comment 6 WebKit Review Bot 2011-11-01 18:21:01 PDT
Comment on attachment 113260 [details]
Patch

Clearing flags on attachment: 113260

Committed r99021: <http://trac.webkit.org/changeset/99021>
Comment 7 WebKit Review Bot 2011-11-01 18:21:06 PDT
All reviewed patches have been landed.  Closing bug.