RESOLVED FIXED 71338
Remove initErrorEvent method 
https://bugs.webkit.org/show_bug.cgi?id=71338
Summary Remove initErrorEvent method
Dominic Cooney
Reported 2011-11-01 16:40:21 PDT
Nobody uses this, so we should un-ship it.
Attachments
Patch (7.17 KB, patch)
2011-11-01 17:08 PDT, Dominic Cooney 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dominic Cooney
Comment 1 2011-11-01 17:08:04 PDT
Created attachment 113260 [details] Patch
Ojan Vafai
Comment 2 2011-11-01 17:14:52 PDT
Comment on attachment 113260 [details] Patch Kill all the inits!
Darin Adler
Comment 3 2011-11-01 17:15:34 PDT
(In reply to comment #0) > Nobody uses this, so we should un-ship it. How do we know nobody uses it?
Ojan Vafai
Comment 4 2011-11-01 17:20:12 PDT
(In reply to comment #3) > (In reply to comment #0) > > Nobody uses this, so we should un-ship it. > > How do we know nobody uses it? We don't know it definitively, but the init*event methods other than for mouse and key events are rarely used and they are being removed from the specs. I think there's a very low risk of sites depending on this.
Dominic Cooney
Comment 5 2011-11-01 17:23:14 PDT
(In reply to comment #3) > How do we know nobody uses it? We think nobody uses it, because this search has no results: <http://codesearch.google.com/#search/&q=initErrorEvent%20lang:js&type=cs> And manually inspecting this broader set of search results didn't turn up any uses: <http://codesearch.google.com/#search/&q=initErrorEvent> Naturally this is not a 100% robust method for determining whether it is used.
WebKit Review Bot
Comment 6 2011-11-01 18:21:01 PDT
Comment on attachment 113260 [details] Patch Clearing flags on attachment: 113260 Committed r99021: <http://trac.webkit.org/changeset/99021>
WebKit Review Bot
Comment 7 2011-11-01 18:21:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.