Bug 71336 - Implement __lookupGetter__/__lookupSetter__ in terms of getPropertyDescriptor
Summary: Implement __lookupGetter__/__lookupSetter__ in terms of getPropertyDescriptor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-01 16:16 PDT by Sam Weinig
Modified: 2011-11-03 10:05 PDT (History)
5 users (show)

See Also:


Attachments
Patch (11.62 KB, patch)
2011-11-01 16:23 PDT, Sam Weinig
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-11-01 16:16:44 PDT
Implement __lookupGetter__/__lookupSetter__ in terms of getPropertyDescriptor
Comment 1 Sam Weinig 2011-11-01 16:23:51 PDT
Created attachment 113250 [details]
Patch
Comment 2 Darin Adler 2011-11-01 16:26:21 PDT
Comment on attachment 113250 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113250&action=review

What’s the performance impact?

> LayoutTests/ChangeLog:10
> +        Update results now that __lookupGetter__/__lookupSetter__ match getOwnPropertyDescriptor.
> +        The failures are tracked by https://bugs.webkit.org/show_bug.cgi?id=71333.

Doesn’t seem great to create new failures.
Comment 3 Sam Weinig 2011-11-01 16:35:11 PDT
(In reply to comment #2)
> (From update of attachment 113250 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=113250&action=review
> 
> What’s the performance impact?
>
> 
> > LayoutTests/ChangeLog:10
> > +        Update results now that __lookupGetter__/__lookupSetter__ match getOwnPropertyDescriptor.
> > +        The failures are tracked by https://bugs.webkit.org/show_bug.cgi?id=71333.
> 
> Doesn’t seem great to create new failures.

I discussed both of these issues with Gavin, and we believe that this implementation will be a bit slower than the last one (though not much, or algorithmaclly) but it is a very infrequently used function and speeding up getPropertyDescriptor would be the preferable thing to spend out time speeding up.  

The failure is also not cool, but I plan to fix it soon, I just wanted to de-virtualize these two functions to make Mark Hahnenberg's life a bit easier.
Comment 4 Sam Weinig 2011-11-01 19:24:55 PDT
Committed r99034: <http://trac.webkit.org/changeset/99034>