Bug 71321 - Fix uses of LayoutUnit in Frame-, Scroll-, and RenderView
Summary: Fix uses of LayoutUnit in Frame-, Scroll-, and RenderView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 63567
  Show dependency treegraph
 
Reported: 2011-11-01 14:22 PDT by Levi Weintraub
Modified: 2011-11-01 23:26 PDT (History)
5 users (show)

See Also:


Attachments
Patch (51.77 KB, patch)
2011-11-01 14:36 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff
Patch (51.95 KB, patch)
2011-11-01 14:40 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff
Patch (33.93 KB, patch)
2011-11-01 16:31 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2011-11-01 14:22:16 PDT
No behavior change yet.
Comment 1 Levi Weintraub 2011-11-01 14:36:27 PDT
Created attachment 113224 [details]
Patch
Comment 2 Levi Weintraub 2011-11-01 14:40:18 PDT
Created attachment 113225 [details]
Patch
Comment 3 WebKit Review Bot 2011-11-01 15:25:40 PDT
Comment on attachment 113225 [details]
Patch

Attachment 113225 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10128399

New failing tests:
fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html
fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html
fast/block/positioning/vertical-rl/fixed-positioning.html
fast/dom/horizontal-scrollbar-in-rtl.html
fast/dom/horizontal-scrollbar-when-dir-change.html
fast/dom/vertical-scrollbar-in-rtl.html
fast/dom/vertical-scrollbar-when-dir-change.html
fast/block/positioning/rtl-fixed-positioning.html
fast/dom/scroll-reveal-top-overflow.html
fast/dom/scroll-reveal-left-overflow.html
Comment 4 Levi Weintraub 2011-11-01 16:31:39 PDT
Created attachment 113252 [details]
Patch
Comment 5 Levi Weintraub 2011-11-01 23:06:49 PDT
Comment on attachment 113252 [details]
Patch

Thanks Darin!
Comment 6 WebKit Review Bot 2011-11-01 23:26:32 PDT
Comment on attachment 113252 [details]
Patch

Clearing flags on attachment: 113252

Committed r99040: <http://trac.webkit.org/changeset/99040>
Comment 7 WebKit Review Bot 2011-11-01 23:26:37 PDT
All reviewed patches have been landed.  Closing bug.