Bug 71312 - until use_skia=1 by default on mac, default port is chromium-cg-mac
Summary: until use_skia=1 by default on mac, default port is chromium-cg-mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: epoger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-01 13:03 PDT by epoger
Modified: 2011-11-02 09:28 PDT (History)
4 users (show)

See Also:


Attachments
Patch (6.12 KB, patch)
2011-11-01 13:06 PDT, epoger
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description epoger 2011-11-01 13:03:05 PDT
Until we finally resolve http://code.google.com/p/chromium/issues/detail?id=101731 ('re-enable use_skia by default'), rniwa has noted that we should change the default port for layout_tests on mac back to chromium-cg-mac.  Otherwise, results will be compared against Skia baselines, even though the code is build with CG instead of Skia.
Comment 1 epoger 2011-11-01 13:06:10 PDT
Created attachment 113206 [details]
Patch
Comment 2 epoger 2011-11-01 13:09:39 PDT
This patch reverts elements of *both* of the following changes, which should have been made together in the first place:

http://trac.webkit.org/changeset/95850 (changed default CPU port for mac from chromium-cg-mac to chromium-mac)

http://trac.webkit.org/changeset/98992 (changed default GPU port for mac from chromium-gpu-cg-mac to chromium-gpu-mac)


Once we set use_skia=1 by default, we should revert this patch.
Comment 3 Adam Barth 2011-11-01 13:18:45 PDT
I'm confused.  I thought we were enabling Skia by default Real Soon Now (tm).
Comment 4 epoger 2011-11-01 13:22:23 PDT
(In reply to comment #3)
> I'm confused.  I thought we were enabling Skia by default Real Soon Now (tm).

See http://code.google.com/p/chromium/issues/detail?id=101731 ... I made that change this morning, but it caused a significant performance regression so I backed it out.

This patch will help deconfuse other developers (hopefully) by making the default layout_tests port match the version that gets built.
Comment 5 Adam Barth 2011-11-01 13:23:04 PDT
Comment on attachment 113206 [details]
Patch

Ah thanks.
Comment 6 epoger 2011-11-01 13:33:32 PDT
I will commit this tomorrow morning so I can keep an eye on things...
Comment 7 WebKit Review Bot 2011-11-02 09:28:00 PDT
Comment on attachment 113206 [details]
Patch

Clearing flags on attachment: 113206

Committed r99068: <http://trac.webkit.org/changeset/99068>
Comment 8 WebKit Review Bot 2011-11-02 09:28:04 PDT
All reviewed patches have been landed.  Closing bug.