Bug 71308 - Switch PopupMenuClient to layout abstraction
Summary: Switch PopupMenuClient to layout abstraction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 63567
  Show dependency treegraph
 
Reported: 2011-11-01 11:45 PDT by Emil A Eklund
Modified: 2011-11-01 17:15 PDT (History)
2 users (show)

See Also:


Attachments
Patch (11.21 KB, patch)
2011-11-01 12:11 PDT, Emil A Eklund
no flags Details | Formatted Diff | Diff
Patch for landing (11.32 KB, patch)
2011-11-01 15:35 PDT, Emil A Eklund
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2011-11-01 11:45:24 PDT
Switch PopupMenuClient and rendering classes implementing it to layout type abstraction.
Comment 1 Emil A Eklund 2011-11-01 12:11:45 PDT
Created attachment 113203 [details]
Patch
Comment 2 Darin Adler 2011-11-01 14:01:33 PDT
Comment on attachment 113203 [details]
Patch

Change log does not offer a rationale for the sites being changed back from LayoutUnit to int.
Comment 3 Emil A Eklund 2011-11-01 14:03:02 PDT
Thanks, I'll make sure to update the ChangeLog to include a justification.
Comment 4 Emil A Eklund 2011-11-01 15:35:13 PDT
Created attachment 113239 [details]
Patch for landing
Comment 5 WebKit Review Bot 2011-11-01 17:15:26 PDT
Comment on attachment 113239 [details]
Patch for landing

Clearing flags on attachment: 113239

Committed r99016: <http://trac.webkit.org/changeset/99016>
Comment 6 WebKit Review Bot 2011-11-01 17:15:31 PDT
All reviewed patches have been landed.  Closing bug.