RESOLVED FIXED 71302
Web Inspector: Add advanced search shortcut to ShortcutsScreen. 
https://bugs.webkit.org/show_bug.cgi?id=71302
Summary Web Inspector: Add advanced search shortcut to ShortcutsScreen.
Vsevolod Vlasov
Reported 2011-11-01 10:22:45 PDT
Add advanced search shortcut to ShortcutsScreen.
Attachments
Patch (2.08 KB, patch)
2011-11-01 10:25 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (3.28 KB, patch)
2011-11-07 02:17 PST, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2011-11-01 10:25:15 PDT
Created attachment 113189 [details] Patch
Daniel Bates
Comment 2 2011-11-01 17:22:30 PDT
Comment on attachment 113189 [details] Patch Attachment 113189 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/10148077
Yury Semikhatsky
Comment 3 2011-11-03 01:32:51 PDT
Comment on attachment 113189 [details] Patch This shortcut conflicts with "Get Into Full Screen Mode" on Mac. r- for now, let's looks for a better shortcut.
Vsevolod Vlasov
Comment 4 2011-11-07 02:17:30 PST
Created attachment 113836 [details] Patch
Vsevolod Vlasov
Comment 5 2011-11-07 02:17:51 PST
Changed mac shortcut to Cmd+Option+F
WebKit Review Bot
Comment 6 2011-11-07 05:54:07 PST
Comment on attachment 113836 [details] Patch Rejecting attachment 113836 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: n/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/10337761
Vsevolod Vlasov
Comment 7 2011-11-07 09:45:55 PST
Committed: http://trac.webkit.org/changeset/99416 Cleared flags and closed.
Note You need to log in before you can comment on or make changes to this bug.