Web Inspector: load source maps via front-end host.
Created attachment 113187 [details] Patch
Comment on attachment 113187 [details] Patch Attachment 113187 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10259031 New failing tests: inspector/debugger/raw-source-code.html
Created attachment 113326 [details] Patch
Could you provide more context and explain why this change is necessary?
Comment on attachment 113326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113326&action=review > Source/WebCore/inspector/front-end/CompilerSourceMapping.js:97 > + callback(true); The function is synchronous, why not get rid of the callback and return the value?
(In reply to comment #4) > Could you provide more context and explain why this change is necessary? Done
Created attachment 113472 [details] Patch
(In reply to comment #5) > (From update of attachment 113326 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=113326&action=review > > > Source/WebCore/inspector/front-end/CompilerSourceMapping.js:97 > > + callback(true); > > The function is synchronous, why not get rid of the callback and return the value? Done.
Comment on attachment 113472 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113472&action=review > Source/WebCore/inspector/InspectorFrontendHost.cpp:262 > + m_frontendPage->mainFrame()->loader()->loadResourceSynchronously(request, DoNotAllowStoredCredentials, error, response, data); What if load fails? We should notify user somehow.
Comment on attachment 113472 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113472&action=review > Source/WebCore/inspector/front-end/CompilerSourceMapping.js:91 > + load: function(callback) Unused param.
Committed r99823: <http://trac.webkit.org/changeset/99823>