Bug 71301 - Web Inspector: load source maps via front-end host.
Summary: Web Inspector: load source maps via front-end host.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-01 10:17 PDT by Pavel Podivilov
Modified: 2011-11-10 01:20 PST (History)
12 users (show)

See Also:


Attachments
Patch (37.41 KB, patch)
2011-11-01 10:20 PDT, Pavel Podivilov
no flags Details | Formatted Diff | Diff
Patch (41.59 KB, patch)
2011-11-02 10:14 PDT, Pavel Podivilov
no flags Details | Formatted Diff | Diff
Patch (42.29 KB, patch)
2011-11-03 06:18 PDT, Pavel Podivilov
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-11-01 10:17:46 PDT
Web Inspector: load source maps via front-end host.
Comment 1 Pavel Podivilov 2011-11-01 10:20:46 PDT
Created attachment 113187 [details]
Patch
Comment 2 WebKit Review Bot 2011-11-01 12:33:42 PDT
Comment on attachment 113187 [details]
Patch

Attachment 113187 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10259031

New failing tests:
inspector/debugger/raw-source-code.html
Comment 3 Pavel Podivilov 2011-11-02 10:14:03 PDT
Created attachment 113326 [details]
Patch
Comment 4 Yury Semikhatsky 2011-11-03 01:22:23 PDT
Could you provide more context and explain why this change is necessary?
Comment 5 Yury Semikhatsky 2011-11-03 01:29:13 PDT
Comment on attachment 113326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113326&action=review

> Source/WebCore/inspector/front-end/CompilerSourceMapping.js:97
> +            callback(true);

The function is synchronous, why not get rid of the callback and return the value?
Comment 6 Pavel Podivilov 2011-11-03 04:25:23 PDT
(In reply to comment #4)
> Could you provide more context and explain why this change is necessary?

Done
Comment 7 Pavel Podivilov 2011-11-03 06:18:17 PDT
Created attachment 113472 [details]
Patch
Comment 8 Pavel Podivilov 2011-11-03 06:18:41 PDT
(In reply to comment #5)
> (From update of attachment 113326 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=113326&action=review
> 
> > Source/WebCore/inspector/front-end/CompilerSourceMapping.js:97
> > +            callback(true);
> 
> The function is synchronous, why not get rid of the callback and return the value?

Done.
Comment 9 Yury Semikhatsky 2011-11-09 23:29:17 PST
Comment on attachment 113472 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113472&action=review

> Source/WebCore/inspector/InspectorFrontendHost.cpp:262
> +    m_frontendPage->mainFrame()->loader()->loadResourceSynchronously(request, DoNotAllowStoredCredentials, error, response, data);

What if load fails? We should notify user somehow.
Comment 10 Yury Semikhatsky 2011-11-09 23:30:54 PST
Comment on attachment 113472 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113472&action=review

> Source/WebCore/inspector/front-end/CompilerSourceMapping.js:91
> +    load: function(callback)

Unused param.
Comment 11 Pavel Podivilov 2011-11-10 01:20:10 PST
Committed r99823: <http://trac.webkit.org/changeset/99823>