Bug 71293 – Change values for WEBKIT_KEYFRAMES_RULE, WEBKIT_KEYFRAME_RULE

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Simon Fraser (smfr)]

http://lists.w3.org/Archives/Public/www-style/2011Nov/0023.html

[Simon Fraser (smfr)]

We should do this to help move animations forward.

[Theresa O'Connor]

Created attachment 126529 [details]
Patch

Patch for review

[Chris Marrin]

Comment on attachment 126529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126529&action=review

Please add a test to verify the correct values

> Source/WebCore/ChangeLog:8
> +        No tests.

We really should have a test. The fact that we didn't before means the error in the values went undetected.

[Theresa O'Connor]

Created attachment 126532 [details]
Patch

Added test per cmarrin's review

[Alexis Menard (darktears)]

Comment on attachment 126532 [details]
Patch

Where is the expected file change?

[Igor Trindade Oliveira]

i think we do not need changes in expected file, because with the change in the test case, it will just show things in the screen if the test fails.

1(In reply to comment #5)
> (From update of attachment 126532 [details])
> Where is the expected file change?

[Alexis Menard (darktears)]

(In reply to comment #6)
> i think we do not need changes in expected file, because with the change in the test case, it will just show things in the screen if the test fails.
> 
> 1(In reply to comment #5)
> > (From update of attachment 126532 [details] [details])
> > Where is the expected file change?

We need as shouldBe will display :

PASS window.CSSRule.WEBKIT_KEYFRAMES_RULE is 7

...

when the condition is verified.

The existing -expected file is full of PASS ... is .... :D

[Theresa O'Connor]

Created attachment 126535 [details]
Patch

Updated -expected per Alexis' comment.

[Alexis Menard (darktears)]

(In reply to comment #8)
> Created an attachment (id=126535) [details]
> Patch
> 
> Updated -expected per Alexis' comment.

Cool thanks.

[WebKit Review Bot]

Comment on attachment 126535 [details]
Patch

Attachment 126535 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11473735

New failing tests:
animations/animation-css-rule-types.html
animations/keyframes-rule.html

[Theresa O'Connor]

Created attachment 126557 [details]
Patch

Fixed failing test and removed redundant changes from the other test.

[WebKit Review Bot]

Comment on attachment 126557 [details]
Patch

Clearing flags on attachment: 126557

Committed r107470: <http://trac.webkit.org/changeset/107470>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.