Bug 71286 - chromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac
Summary: chromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: epoger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-01 07:56 PDT by epoger
Modified: 2011-11-01 12:29 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.23 KB, patch)
2011-11-01 07:59 PDT, epoger
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description epoger 2011-11-01 07:56:42 PDT
chromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac
Comment 1 epoger 2011-11-01 07:57:32 PDT
(this should be kept in sync with what port we default to on mac, chromium-mac or chromium-cg-mac)
Comment 2 epoger 2011-11-01 07:59:44 PDT
Created attachment 113172 [details]
Patch
Comment 3 Stephen White 2011-11-01 10:25:55 PDT
Comment on attachment 113172 [details]
Patch

Elliot assures me this will only affect the trybots, and not the waterfall bots, so assuming that's true, this looks good.  :)  r=me
Comment 4 epoger 2011-11-01 10:28:01 PDT
The need for this change is to fix chromium trybot behavior as noted in http://codereview.chromium.org/8384004/ ('Set use_skia=1 by default'): currently, the trybots
are evaluating webkit_tests against the "chromium-mac-snowleopard" port (i.e.
Skia), but evaluating webkit_gpu_tests against the
"chromium-gpu-cg-mac-snowleopard" port (CG).

Note that this change will not affect the chromium.webkit waterfall, because those bots already manually specify either chromium-gpu-mac or chromium-gpu-cg-mac.
Comment 5 WebKit Review Bot 2011-11-01 12:29:07 PDT
Comment on attachment 113172 [details]
Patch

Clearing flags on attachment: 113172

Committed r98992: <http://trac.webkit.org/changeset/98992>
Comment 6 WebKit Review Bot 2011-11-01 12:29:11 PDT
All reviewed patches have been landed.  Closing bug.