Bug 71284 - [skia] call readPixels on canvas instead of device (will be private on device soon) and check for error
Summary: [skia] call readPixels on canvas instead of device (will be private on device...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Reed
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-01 06:41 PDT by Mike Reed
Modified: 2011-11-01 08:59 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.22 KB, patch)
2011-11-01 06:42 PDT, Mike Reed
no flags Details | Formatted Diff | Diff
Patch (3.34 KB, patch)
2011-11-01 07:11 PDT, Mike Reed
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Reed 2011-11-01 06:41:14 PDT
[skia] call readPixels on canvas instead of device (will be private on device soon) and check for error
Comment 1 Mike Reed 2011-11-01 06:42:09 PDT
Created attachment 113166 [details]
Patch
Comment 2 Stephen White 2011-11-01 06:56:13 PDT
Comment on attachment 113166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113166&action=review

OK.  r=me

> Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp:239
>      unsigned destBytesPerRow = 4 * rect.width();

Nit:  This line could be moved below the readPixels() call (not new to this patch, though).
Comment 3 Mike Reed 2011-11-01 07:11:04 PDT
Created attachment 113168 [details]
Patch
Comment 4 Mike Reed 2011-11-01 07:11:36 PDT
moved computation of destinationRowBytes to after failure-check on readPixels.
Comment 5 Stephen White 2011-11-01 07:47:00 PDT
Comment on attachment 113168 [details]
Patch

Looks good.  r=me
Comment 6 WebKit Review Bot 2011-11-01 08:59:24 PDT
Comment on attachment 113168 [details]
Patch

Clearing flags on attachment: 113168

Committed r98969: <http://trac.webkit.org/changeset/98969>
Comment 7 WebKit Review Bot 2011-11-01 08:59:28 PDT
All reviewed patches have been landed.  Closing bug.