Bug 71280 - [Qt] Merge common desktop and touch APIs under an abstract base class.
Summary: [Qt] Merge common desktop and touch APIs under an abstract base class.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jocelyn Turcotte
URL:
Keywords:
Depends on: 71311
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-01 04:41 PDT by Jocelyn Turcotte
Modified: 2011-11-02 09:48 PDT (History)
6 users (show)

See Also:


Attachments
Patch (55.46 KB, patch)
2011-11-01 04:52 PDT, Jocelyn Turcotte
no flags Details | Formatted Diff | Diff
Patch (57.67 KB, patch)
2011-11-01 08:31 PDT, Jocelyn Turcotte
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2011-11-01 04:41:53 PDT
[Qt] Merge common desktop and touch APIs under an abstract base class.
Comment 1 Jocelyn Turcotte 2011-11-01 04:52:44 PDT
Created attachment 113157 [details]
Patch
Comment 2 WebKit Review Bot 2011-11-01 04:54:03 PDT
Attachment 113157 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/API/qt/qabstractwebview_p.h:35:  q_ptr is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/qt/qabstractwebview.h:85:  d_ptr is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexis Menard (darktears) 2011-11-01 05:23:00 PDT
Comment on attachment 113157 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113157&action=review

Usually in Qt abstract classes have at least one pure virtual method.

> Source/WebKit2/UIProcess/API/qt/qabstractwebview.h:59
> +    // FIXME: We inherit from QSGPaintedItem until QDesktopWebView works on top of a plain QSGItem.

QQuickPaintedItem rather than QSGPaintedItem. QSGItem -> QQuickItem

> Source/WebKit2/UIProcess/API/qt/qabstractwebview.h:80
> +    void linkHovered(const QUrl& url, const QString& title);

I think this should be only in the desktopwebview for now.
Comment 4 Jocelyn Turcotte 2011-11-01 08:31:49 PDT
Created attachment 113174 [details]
Patch

- Renamed QAbstractWebView to QBaseWebView.
- renamed QtWebPageProxy instances from page to pageProxy.
- Changed the type of QTouchWebPagePrivate::pageProxy from QtTouchWebPageProxy to QtWebPageProxy to make its scope simillar to Q*WebView.
- Moved linkHovered back to QDesktopWebView.
Comment 5 WebKit Review Bot 2011-11-01 08:38:27 PDT
Attachment 113174 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/API/qt/qbasewebview_p.h:35:  q_ptr is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/qt/qbasewebview.h:84:  d_ptr is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Andreas Kling 2011-11-01 10:00:02 PDT
Comment on attachment 113174 [details]
Patch

Me gusta.
Comment 7 Jocelyn Turcotte 2011-11-01 10:05:42 PDT
Comment on attachment 113174 [details]
Patch

Clearing flags on attachment: 113174

Committed r98973: <http://trac.webkit.org/changeset/98973>
Comment 8 Jocelyn Turcotte 2011-11-01 10:05:50 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Alexis Menard (darktears) 2011-11-01 13:52:40 PDT
(In reply to comment #8)
> All reviewed patches have been landed.  Closing bug.

http://build.webkit.sed.hu/builders/x86-32%20Linux%20Qt%20Release%20WebKit2/builds/14403/steps/API%20tests/logs/stdio

it broke the QML API tests.
Comment 10 Jocelyn Turcotte 2011-11-02 09:48:23 PDT
Fixed the API tests.

Committed r99073: <http://trac.webkit.org/changeset/99073>