Bug 71279 – [Qt] Create infrastructure for Qt's builtin bundle in web process.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Caio Marcelo de Oliveira Filho]

[Qt] Create infrastructure for Qt's builtin bundle in web process.

[Caio Marcelo de Oliveira Filho]

Created attachment 113156 [details]
Patch

[Simon Hausmann]

Comment on attachment 113156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113156&action=review

I suggest renaming QtBundle to QtBuiltinBundle

> Source/WebKit2/WebProcess/qt/QtBundle.cpp:47
> +void QtBundle::initialize(WKBundleRef bundle, WKTypeRef initializationUserData)

initializationUserData seems to be an unused parameter.

> Source/WebKit2/WebProcess/qt/QtBundle.cpp:79
> +    size_t size = m_pages.size();
> +    for (size_t i = 0; i < size; ++i) {

I'd prefer to use of m_page.size() instead of the local size variable. It's not that calling m_pages.size() is expensive ;)

> Source/WebKit2/WebProcess/qt/QtBundle.cpp:90
> +    size_t size = m_pages.size();
> +    for (size_t i = 0; i < size; ++i) {

Same here.

> Source/WebKit2/WebProcess/qt/WebProcessQt.cpp:99
> +        m_injectedBundle->loadWithFunction(qt_wk_WKBundleInitialize);

Why add loadWithFunction to the generic InjectedBundle when you could simply call QtBundle::shared().initialize(toAPI(m_injectedBundle), 0); right there?

[Caio Marcelo de Oliveira Filho]

Created attachment 113165 [details]
Patch

[Simon Hausmann]

Comment on attachment 113165 [details]
Patch

r=me

[Caio Marcelo de Oliveira Filho]

Committed r98957: <http://trac.webkit.org/changeset/98957>