The following layout tests occasionally crash on win gpu: media/video-source.html media/video-src-change.html media/video-transformed.html This started somewhere around r98583:r98705
You see the following in the dashboard. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&group=%40ToT%20GPU%20Mesa%20-%20chromium.org&tests=media%2Fvideo-volume-slider.html ASSERTION FAILED: !m_visibleDescendantStatusDirty third_party/WebKit/Source/WebCore/rendering/RenderLayer.h(390) : bool WebCore::RenderLayer::hasVisibleDescendant() const 1 0x15e35fa 2 0x15e0196 3 0x15dff90 4 0x15e030c 5 0x15df138 6 0x15eab2b 7 0x15eaab2 8 0x15e818c 9 0x165b9f9 10 0xc5c63e 11 0xc54efa 12 0x1291456 13 0x4966fc 14 0x4e67e6 15 0x4ea12a 16 0x11f8a67 17 0x11f7ef4 18 0x11d9aa4 19 0x11d9b52 20 0x11d9db8 21 0x120ce3b 22 0x1220a25 23 0x120e374 24 0x1221334 25 0x4fc96e 26 0x1a792fa 27 0x1b39128 28 0x1b3e5e2 29 0x6815b7 30 0x69c729 31 0x69c843 [17706:17706:16992128521455:ERROR:process_util_posix.cc(134)] Received signal 11 base::debug::StackTrace::StackTrace() [0x70fcaa] base::(anonymous namespace)::StackDumpSignalHandler() [0x6c49c9] 0x2ac79b8d2af0 WebCore::RenderLayer::hasVisibleDescendant() [0x15e35ff] WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendants() [0x15e0196] WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer() [0x15dff90] WebCore::RenderLayerBacking::containsPaintedContent() [0x15e030c] WebCore::RenderLayerBacking::updateDrawsContent() [0x15df138] WebCore::RenderLayerCompositor::rootLayerAttachmentChanged() [0x15eab2b] WebCore::RenderLayerCompositor::detachRootLayer() [0x15eaab2] WebCore::RenderLayerCompositor::willMoveOffscreen() [0x15e818c] WebCore::RenderView::willMoveOffscreen() [0x165b9f9] WebCore::Document::documentWillBecomeInactive() [0xc5c63e] WebCore::Document::detach() [0xc54efa] WebCore::Frame::setView() [0x1291456] WebKit::WebFrameImpl::createFrameView() [0x4966fc] WebKit::FrameLoaderClientImpl::makeDocumentView() [0x4e67e6] WebKit::FrameLoaderClientImpl::transitionToCommittedForNewPage() [0x4ea12a] WebCore::FrameLoader::transitionToCommitted() [0x11f8a67] WebCore::FrameLoader::commitProvisionalLoad() [0x11f7ef4] WebCore::DocumentLoader::commitIfReady() [0x11d9aa4] WebCore::DocumentLoader::commitLoad() [0x11d9b52] WebCore::DocumentLoader::receivedData() [0x11d9db8] WebCore::MainResourceLoader::addData() [0x120ce3b] WebCore::ResourceLoader::didReceiveData() [0x1220a25] WebCore::MainResourceLoader::didReceiveData() [0x120e374] WebCore::ResourceLoader::didReceiveData() [0x1221334] WebCore::ResourceHandleInternal::didReceiveData() [0x4fc96e] webkit_glue::WebURLLoaderImpl::Context::OnReceivedData() [0x1a792fa] (anonymous namespace)::RequestProxy::NotifyReceivedData() [0x1b39128] base::internal::Invoker2<>::DoInvoke() [0x1b3e5e2] base::Callback<>::Run() [0x6815b7] MessageLoop::RunTask() [0x69c729] MessageLoop::DeferOrRunPendingTask() [0x69c843] MessageLoop::DoWork() [0x69d065] base::MessagePumpGlib::RunWithDispatcher() [0x700ced] base::MessagePumpGlib::Run() [0x7010ce] MessageLoop::RunInternal() [0x69c3ab] MessageLoop::RunHandler() [0x69c25e] MessageLoop::Run() [0x69bc17] webkit_support::RunMessageLoop() [0x611b82] TestShell::waitTestFinished() [0x4651c1] TestShell::runFileTest() [0x45dae6] runTest() [0x431218] main [0x431c70] 0x2ac79b8bdc4d 0x41e159
Possible blamelist http://trac.webkit.org/log/?verbose=on&rev=98750&stop_rev=98585 RenderingLayer change: http://trac.webkit.org/changeset/98735/trunk/Source/WebCore/rendering/RenderLayer.cpp
I think the following addition of assertion causes the crash. http://trac.webkit.org/changeset/98735/trunk/Source/WebCore/rendering/RenderLayer.h Simon, do you have any input on this?
We can remove that assertion until the callers are fixed. I'm at TPAC this week; can someone else take care of it?
Created attachment 113193 [details] patch
Attachment 113193 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 ERROR: FAILURES FOR <lucid, x86_64, release, cpu> in LayoutTests/platform/chromium/test_expectations.txt ERROR: Line:1134 Duplicate or ambiguous expectation. media/video-volume-slider.html LayoutTests/platform/chromium/test_expectations.txt:1134: Duplicate or ambiguous expectation. media/video-volume-slider.html [test/expectations] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 113193 [details] patch Clearing flags on attachment: 113193 Committed r98978: <http://trac.webkit.org/changeset/98978>
Thank you for quick action on this!
Can this one be considered RESOLVED FIXED?
Oops, sorry, I guess this was being kept open b/c there was a desire to add the removed ASSERT back in once "callers are fixed" (see comment #4 above).