Bug 71266 – CSS2:text-decoration: <rt> element should not inherit text-decoration property

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Hiroshi Takase]

Created attachment 113132 [details]
HTML source

Text-decoration property does not inherit.  So <rt> element should not be underlined if <rt> element itself is not specified "text-decoration" property and the parent element is specified "text-decoration:underline".

[Koji Ishii]

Here's the discussion on this at www-style:
http://lists.w3.org/Archives/Public/www-style/2011Sep/0238.html

[Koji Ishii]

I'd like to work on this one.

[Koji Ishii]

Created attachment 127519 [details]
Prevent text-decoration propagation for rt tag if it has its default treatment of block

Turned out that the diff is just one line. A new reftest is included.

[Koji Ishii]

Now I wonder, maybe tests should be in fast/ruby instead of fast/css, because the test requires ruby and CSS2. Any suggestions appreciated.

[Koji Ishii]

Comment on attachment 127519 [details]
Prevent text-decoration propagation for rt tag if it has its default treatment of block

I'd like to take a different approach.

[Koji Ishii]

In bug 18611, the fix is made to RenderObject::getTextDecorationColors. Which is the correct place to fix?

[Koji Ishii]

Created attachment 128170 [details]
patch: Prevent text-decoration propagation for rt tag if it has its default treatment of block

Previous patch modified CSSStyleSelector::adjustRenderStyle, but I found a similar bug 18611, which fixes RenderObject::getTextDecorationColors instead, so this patch follows that.

Two things are different from the previous patch:
* The check is slightly faster than the previous patch (one virtual call on paint(), while the previous patch checks two fields on attach().)
* The -webkit-text-decoration-in-effect was not set in the previous patch, but is set in this patch.

reftest is included. This is slightly improved from the previous patch.

[Koji Ishii]

Comment on attachment 128170 [details]
patch: Prevent text-decoration propagation for rt tag if it has its default treatment of block

Could someone please review this patch?

[Kentaro Hara]

Comment on attachment 128170 [details]
patch: Prevent text-decoration propagation for rt tag if it has its default treatment of block

View in context: https://bugs.webkit.org/attachment.cgi?id=128170&action=review

> Source/WebCore/ChangeLog:7
> +

Would you please add the link to the spec that supports this change?

[Koji Ishii]

Created attachment 128416 [details]
patch: Prevent text-decoration propagation for rt tag if it has its default treatment of block

Added the link to the spec that supports this change, and also to a discussion at www-style to confirm it to the ChangeLogs.

[Kentaro Hara]

Comment on attachment 128416 [details]
patch: Prevent text-decoration propagation for rt tag if it has its default treatment of block

Makes sense!

[WebKit Review Bot]

Comment on attachment 128416 [details]
patch: Prevent text-decoration propagation for rt tag if it has its default treatment of block

Rejecting attachment 128416 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[Kentaro Hara]

Just right now something wrong seems to be happening on the WebKit svn server. Let me commit it again after the issue is solved.

[WebKit Review Bot]

Comment on attachment 128416 [details]
patch: Prevent text-decoration propagation for rt tag if it has its default treatment of block

Rejecting attachment 128416 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[Kentaro Hara]

Comment on attachment 128416 [details]
patch: Prevent text-decoration propagation for rt tag if it has its default treatment of block

It seems strange. As far as I see committers.py, I am in the reviewer list and no change had been made to the list recently. Let me try r+ again.

[WebKit Review Bot]

Comment on attachment 128416 [details]
patch: Prevent text-decoration propagation for rt tag if it has its default treatment of block

Clearing flags on attachment: 128416

Committed r108690: <http://trac.webkit.org/changeset/108690>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.