Switch RenderObject to layout type abstraction.
Created attachment 113097 [details] Patch
Comment on attachment 113097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113097&action=review > Source/WebCore/rendering/RenderObject.cpp:794 > + int width = roundf((side == BSTop || side == BSBottom ? y2 - y1 : x2 - x1)); The round function specifically takes a “float” so is not appropriate to round a LayoutUnit to an int. If LayoutUnit was a double or int it would be quite inefficient! > Source/WebCore/rendering/RenderObject.h:1052 > -inline int adjustForAbsoluteZoom(int value, RenderObject* renderer) > +inline float adjustForAbsoluteZoom(int value, RenderObject* renderer) I think this change should be landed separately with its own review and rationale.
Created attachment 113107 [details] Patch
(In reply to comment #2) > The round function specifically takes a “float” so is not appropriate to round a LayoutUnit to an int. If LayoutUnit was a double or int it would be quite inefficient! Good catch, I should have caught that. Thanks! > > > Source/WebCore/rendering/RenderObject.h:1052 > > -inline int adjustForAbsoluteZoom(int value, RenderObject* renderer) > > +inline float adjustForAbsoluteZoom(int value, RenderObject* renderer) > > I think this change should be landed separately with its own review and rationale. Reverted this change, leaving it for later. Please take another look.
Comment on attachment 113107 [details] Patch Patch looks good, but does not apply in the EWS.
Created attachment 113115 [details] Patch
Comment on attachment 113115 [details] Patch Attachment 113115 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/10241949
Created attachment 113191 [details] Patch
Thanks Darin!
Comment on attachment 113191 [details] Patch Clearing flags on attachment: 113191 Committed r99008: <http://trac.webkit.org/changeset/99008>
All reviewed patches have been landed. Closing bug.