Bug 71239 - update results for /media/track/track-mutable-expected.txt and /media/track/track-text-track-cue-list-expected.txt
Summary: update results for /media/track/track-mutable-expected.txt and /media/track/t...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anna Cavender
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-31 15:07 PDT by Anna Cavender
Modified: 2011-11-02 16:35 PDT (History)
3 users (show)

See Also:


Attachments
Patch (9.17 KB, patch)
2011-10-31 15:11 PDT, Anna Cavender
no flags Details | Formatted Diff | Diff
updating to ToT (6.88 KB, patch)
2011-11-01 08:19 PDT, Anna Cavender
tonyg: review-
annacc: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anna Cavender 2011-10-31 15:07:04 PDT
Update the results of these tests to match current implementation progress.
Comment 1 Anna Cavender 2011-10-31 15:11:49 PDT
Created attachment 113090 [details]
Patch
Comment 2 Anna Cavender 2011-11-01 08:19:40 PDT
Created attachment 113173 [details]
updating to ToT
Comment 3 WebKit Review Bot 2011-11-01 09:13:37 PDT
Comment on attachment 113173 [details]
updating to ToT

Rejecting attachment 113173 [details] from review queue.

imasaki@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 4 Tony Gentilcore 2011-11-01 09:31:14 PDT
Comment on attachment 113173 [details]
updating to ToT

View in context: https://bugs.webkit.org/attachment.cgi?id=113173&action=review

> LayoutTests/media/track/track-mutable-expected.txt:6
> +TypeError: Cannot read property 'length' of undefined

We don't usually like to check in expectations that aren't correct. Usually we check in the correct expectations, mark the test as failing, and work up to matching the correct expectations. The exception is that sometimes we'll check in incorrect expectations for a specific platform, but this patch is modifying the platform independent version.

Maybe you can provide some more background about what you are trying to achieve.

> LayoutTests/platform/chromium/test_expectations.txt:-82
> -BUGWK43668 SKIP : media/track/track-mutable.html = TIMEOUT

For example, instead completely removing the SKIP, it is more typical to allow it to run but expect that there is a text difference in the results:
BUGWK43668 : media/track/track-mutable.html = TEXT
Comment 5 Anna Cavender 2011-11-01 09:39:00 PDT
Sam, what is your preference for incremental changes to a big feature?  (1) Test results that pass because they have wrong values that become correct later as more of a feature is implemented?  Or (2) tests results that have the ideal values and are marked failing with TEXT until they one day pass?
Comment 6 Anna Cavender 2011-11-02 16:35:30 PDT
Decided to delete these tests until the functionality they test is available.
http://trac.webkit.org/changeset/99110