Bug 71239 – update results for /media/track/track-mutable-expected.txt and /media/track/track-text-track-cue-list-expected.txt

• Status: RESOLVED
• Resolution: INVALID
• Component: Media

[Anna Cavender]

Update the results of these tests to match current implementation progress.

[Anna Cavender]

Created attachment 113090 [details]
Patch

[Anna Cavender]

Created attachment 113173 [details]
updating to ToT

[WebKit Review Bot]

Comment on attachment 113173 [details]
updating to ToT

Rejecting attachment 113173 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[Tony Gentilcore]

Comment on attachment 113173 [details]
updating to ToT

View in context: https://bugs.webkit.org/attachment.cgi?id=113173&action=review

> LayoutTests/media/track/track-mutable-expected.txt:6
> +TypeError: Cannot read property 'length' of undefined

We don't usually like to check in expectations that aren't correct. Usually we check in the correct expectations, mark the test as failing, and work up to matching the correct expectations. The exception is that sometimes we'll check in incorrect expectations for a specific platform, but this patch is modifying the platform independent version.

Maybe you can provide some more background about what you are trying to achieve.

> LayoutTests/platform/chromium/test_expectations.txt:-82
> -BUGWK43668 SKIP : media/track/track-mutable.html = TIMEOUT

For example, instead completely removing the SKIP, it is more typical to allow it to run but expect that there is a text difference in the results:
BUGWK43668 : media/track/track-mutable.html = TEXT

[Anna Cavender]

Sam, what is your preference for incremental changes to a big feature?  (1) Test results that pass because they have wrong values that become correct later as more of a feature is implemented?  Or (2) tests results that have the ideal values and are marked failing with TEXT until they one day pass?

[Anna Cavender]

Decided to delete these tests until the functionality they test is available.
http://trac.webkit.org/changeset/99110