Bug 71238 - Switch RoundedRect back to integers
Summary: Switch RoundedRect back to integers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 63567
  Show dependency treegraph
 
Reported: 2011-10-31 14:50 PDT by Levi Weintraub
Modified: 2011-10-31 18:09 PDT (History)
4 users (show)

See Also:


Attachments
Patch (11.64 KB, patch)
2011-10-31 15:05 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff
Patch (12.11 KB, patch)
2011-10-31 15:58 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2011-10-31 14:50:49 PDT
Our conversion of RoundedRect to LayoutUnits was premature. As most painting should still be aligned to pixel boundaries, this graphics class should remain int-based.
Comment 1 Levi Weintraub 2011-10-31 15:05:05 PDT
Created attachment 113088 [details]
Patch
Comment 2 Early Warning System Bot 2011-10-31 15:17:57 PDT
Comment on attachment 113088 [details]
Patch

Attachment 113088 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10250065
Comment 3 WebKit Review Bot 2011-10-31 15:36:45 PDT
Comment on attachment 113088 [details]
Patch

Attachment 113088 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10250071
Comment 4 Levi Weintraub 2011-10-31 15:58:28 PDT
Created attachment 113098 [details]
Patch
Comment 5 Darin Adler 2011-10-31 16:03:54 PDT
Comment on attachment 113098 [details]
Patch

OK.
Comment 6 Levi Weintraub 2011-10-31 16:04:30 PDT
Comment on attachment 113098 [details]
Patch

Thanks Darin!
Comment 7 WebKit Review Bot 2011-10-31 18:09:19 PDT
Comment on attachment 113098 [details]
Patch

Clearing flags on attachment: 113098

Committed r98931: <http://trac.webkit.org/changeset/98931>
Comment 8 WebKit Review Bot 2011-10-31 18:09:24 PDT
All reviewed patches have been landed.  Closing bug.