Bug 71235 - No-svg build is broken
Summary: No-svg build is broken
Status: RESOLVED DUPLICATE of bug 71247
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-31 13:37 PDT by Viatcheslav Ostapenko
Modified: 2011-10-31 17:04 PDT (History)
1 user (show)

See Also:

Attachments
Add #if ENABLE(SVG) to fix no-svg build (1.15 KB, patch)
2011-10-31 13:41 PDT, Viatcheslav Ostapenko 		krit: review+
krit: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Viatcheslav Ostapenko 2011-10-31 13:37:08 PDT 
Unguarded reference to SVGImage in RenderBox* RenderImage::embeddedContentBox() const
Comment 1 Viatcheslav Ostapenko 2011-10-31 13:41:57 PDT 
Created attachment 113081 [details]
Add #if ENABLE(SVG) to fix no-svg build
Comment 2 Dirk Schulze 2011-10-31 14:14:41 PDT 
Comment on attachment 113081 [details]
Add #if ENABLE(SVG) to fix no-svg build

LGTM. r=me
Comment 3 Alexey Proskuryakov 2011-10-31 17:04:30 PDT 
Comment on attachment 113081 [details]
Add #if ENABLE(SVG) to fix no-svg build

View in context: https://bugs.webkit.org/attachment.cgi?id=113081&action=review

> Source/WebCore/ChangeLog:10
> +        No new tests. (OOPS!)

A patch cannot be landed with this line, pre-commit hook would forbid that.

> Source/WebCore/rendering/RenderImage.cpp:547
>      RefPtr<Image> image = m_imageResource->image();

Wouldn't the build remain broken because of unused variable?
Comment 4 Alexey Proskuryakov 2011-10-31 17:04:43 PDT 
This was already fixed.

*** This bug has been marked as a duplicate of bug 71247 ***