webkitpy tests depend too much on the user's environment
Created attachment 113080 [details] Patch
Did you just change the subject to be grammatically incorrect? :)
Comment on attachment 113080 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113080&action=review change looks basically good, with a few nits. > Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:187 > + # FIXME: Note we do not pass a filesystem as the "test port" magically suplies its own mock filesystem. Why add the FIXME here? > Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py:116 > + port = self.make_port(executive=executive) The whole point of this test is that we're actually testing the implementation of wdiff, so we have to use a real executive. This should be renamed to integration_test_run_wdiff() instead (I think this test predates the concept of integration tests).
Thanks. Updated per your comments.
Committed r98877: <http://trac.webkit.org/changeset/98877>