RESOLVED FIXED 71223
CSSRule: Devirtualize insertedIntoParent() 
https://bugs.webkit.org/show_bug.cgi?id=71223
Summary CSSRule: Devirtualize insertedIntoParent()
Andreas Kling
Reported 2011-10-31 08:57:14 PDT
This one is only needed by CSSImportRule.
Attachments
Probably a patch (3.32 KB, patch)
2011-10-31 09:01 PDT, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-10-31 09:01:57 PDT
Created attachment 113055 [details] Probably a patch
Andreas Kling
Comment 2 2011-10-31 09:03:39 PDT
Comment on attachment 113055 [details] Probably a patch Oopsie loopsie..
Andreas Kling
Comment 3 2011-10-31 09:07:43 PDT
Comment on attachment 113055 [details] Probably a patch False alarm, I had an unrelated local build failure.
Antti Koivisto
Comment 4 2011-10-31 09:18:45 PDT
Comment on attachment 113055 [details] Probably a patch View in context: https://bugs.webkit.org/attachment.cgi?id=113055&action=review r=me, with a comment. > Source/WebCore/css/CSSImportRule.cpp:112 > -void CSSImportRule::insertedIntoParent() > +void CSSImportRule::insertedIntoStyleSheet() Maybe a name that describes what it actually does? Something like "requestStyleSheet". Or perharps the loading code should actually live in CSSStyleSheet?
Luke Macpherson
Comment 5 2011-10-31 09:32:53 PDT
Comment on attachment 113055 [details] Probably a patch View in context: https://bugs.webkit.org/attachment.cgi?id=113055&action=review > Source/WebCore/css/CSSStyleSheet.cpp:91 > + if (c->isImportRule()) Given that c->isImportRule() is virtual, I'm not sure that this buys anything in terms of performance (in fact it is probably immeasurably slower).
Luke Macpherson
Comment 6 2011-10-31 09:42:03 PDT
My apologies, I hadn't seen https://bugs.webkit.org/show_bug.cgi?id=71221 which will devirtualize isimportRule().
Andreas Kling
Comment 7 2011-10-31 10:03:23 PDT
Committed r98861: <http://trac.webkit.org/changeset/98861>
Note You need to log in before you can comment on or make changes to this bug.