This one is only needed by CSSImportRule.
Created attachment 113055 [details] Probably a patch
Comment on attachment 113055 [details] Probably a patch Oopsie loopsie..
Comment on attachment 113055 [details] Probably a patch False alarm, I had an unrelated local build failure.
Comment on attachment 113055 [details] Probably a patch View in context: https://bugs.webkit.org/attachment.cgi?id=113055&action=review r=me, with a comment. > Source/WebCore/css/CSSImportRule.cpp:112 > -void CSSImportRule::insertedIntoParent() > +void CSSImportRule::insertedIntoStyleSheet() Maybe a name that describes what it actually does? Something like "requestStyleSheet". Or perharps the loading code should actually live in CSSStyleSheet?
Comment on attachment 113055 [details] Probably a patch View in context: https://bugs.webkit.org/attachment.cgi?id=113055&action=review > Source/WebCore/css/CSSStyleSheet.cpp:91 > + if (c->isImportRule()) Given that c->isImportRule() is virtual, I'm not sure that this buys anything in terms of performance (in fact it is probably immeasurably slower).
My apologies, I hadn't seen https://bugs.webkit.org/show_bug.cgi?id=71221 which will devirtualize isimportRule().
Committed r98861: <http://trac.webkit.org/changeset/98861>