Bug 71219 - [Qt] Make QWebPreferences hold a QtWebPageProxy
Summary: [Qt] Make QWebPreferences hold a QtWebPageProxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Marcelo de Oliveira Filho
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-10-31 05:37 PDT by Caio Marcelo de Oliveira Filho
Modified: 2011-10-31 06:51 PDT (History)
3 users (show)

See Also:


Attachments
Patch (15.09 KB, patch)
2011-10-31 06:16 PDT, Caio Marcelo de Oliveira Filho
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Marcelo de Oliveira Filho 2011-10-31 05:37:04 PDT
Currently it holds a WKPreferencesRef, but in the future we will have features in our port that are not controlled by this C API. Changing it to hold a QtWebPageProxy is more flexible.
Comment 1 Caio Marcelo de Oliveira Filho 2011-10-31 06:16:26 PDT
Created attachment 113043 [details]
Patch
Comment 2 Alexis Menard (darktears) 2011-10-31 06:24:20 PDT
Comment on attachment 113043 [details]
Patch

I think it's a good thing. At some point we will have to add APIs that are not in the C API but still public.
Comment 3 Andreas Kling 2011-10-31 06:31:59 PDT
Comment on attachment 113043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113043&action=review

Great idea, r=me!

> Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp:108
> -    , m_preferences(0)
> +    , m_preferences()

Remove this line completely.
Comment 4 Caio Marcelo de Oliveira Filho 2011-10-31 06:51:41 PDT
Committed r98851: <http://trac.webkit.org/changeset/98851>