Bug 71213 – [EFL] Added ewk_tile_memory_size_get function

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Tomasz Morawski]

Added the ewk_tile_memory_size_get function returns size of used memory by given tile. Simplify and cleanup the code.

[Tomasz Morawski]

Created attachment 113029 [details]
added new function

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 113029 [details]
added new function

View in context: https://bugs.webkit.org/attachment.cgi?id=113029&action=review

> Source/WebKit/efl/ewk/ewk_tiled_model.cpp:347
> +size_t ewk_tile_memory_size_get(Ewk_Tile* tile)

I'd make `tile' const.

[Tomasz Morawski]

Created attachment 113284 [details]
Added const

[Raphael Kubo da Costa (:rakuco)]

LGTM.

[KwangHyuk]

> Source/WebKit/efl/ewk/ewk_tiled_model.h:34
> +size_t ewk_tile_memory_size_get(const Ewk_Tile* t);

I prefer tile instead of t although other existing API is still using it. :)

[Tomasz Morawski]

(In reply to comment #5)
> > Source/WebKit/efl/ewk/ewk_tiled_model.h:34
> > +size_t ewk_tile_memory_size_get(const Ewk_Tile* t);
> 
> I prefer tile instead of t although other existing API is still using it. :)
So, I think the "tile" name will look badly in courrent API implementation. So, it could be changed when existing API will be updated form "t" to "tile".

[KwangHyuk]

LGTM.

[WebKit Review Bot]

Comment on attachment 113284 [details]
Added const 

Clearing flags on attachment: 113284

Committed r99252: <http://trac.webkit.org/changeset/99252>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.