[Chromium] The Chromium port calls OwnPtr::get and RefPtr::get way more often than needed
Created attachment 113015 [details] Patch
Comment on attachment 113015 [details] Patch Attachment 113015 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10242684
Comment on attachment 113015 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113015&action=review > Source/WebKit/chromium/ChangeLog:9 > + calling get() on these pointer types. This patch cleans up most (all?) Nit: one space after period. > Source/WebKit/chromium/src/WebViewImpl.cpp:2180 > + HTMLInputElement* inputElem = static_cast<HTMLInputElement*>(focusedNode.get()); Can we call Node::toInputElement here?
Comment on attachment 113015 [details] Patch Sigh. WebPrivatePtr makes this trickier.
> > Source/WebKit/chromium/src/WebViewImpl.cpp:2180 > > + HTMLInputElement* inputElem = static_cast<HTMLInputElement*>(focusedNode.get()); > > Can we call Node::toInputElement here? Yeah, that would be better. This code looks sketchy.
Comment on attachment 113015 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113015&action=review > Source/WebKit/chromium/src/WebIDBKey.cpp:128 > - if (!m_private.get()) > + if (!m_private) Apparently this one is WebPrivatePtr :(
(In reply to comment #5) > > > Source/WebKit/chromium/src/WebViewImpl.cpp:2180 > > > + HTMLInputElement* inputElem = static_cast<HTMLInputElement*>(focusedNode.get()); > > > > Can we call Node::toInputElement here? > > Yeah, that would be better. This code looks sketchy. I'm seeing a horror a few lines beneath that: 2185 m_autofillPopupClient = adoptPtr(new AutofillPopupMenuClient);
Created attachment 113017 [details] Patch
Comment on attachment 113017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113017&action=review > Source/WebKit/chromium/src/WebViewImpl.cpp:2180 > + HTMLInputElement* inputElem = static_cast<HTMLInputElement*>(focusedNode.get()); Please do focusedNode->toInputElement();
Created attachment 113018 [details] Patch for landing
Comment on attachment 113018 [details] Patch for landing Clearing flags on attachment: 113018 Committed r98837: <http://trac.webkit.org/changeset/98837>
All reviewed patches have been landed. Closing bug.