Bug 71184 - Move checkIntersection/checkEnclosure from RenderSVGModelObject to SVGRenderSupport
Summary: Move checkIntersection/checkEnclosure from RenderSVGModelObject to SVGRenderS...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Schulze
URL:
Keywords:
Depends on:
Blocks: 11274
  Show dependency treegraph
 
Reported: 2011-10-30 03:52 PDT by Dirk Schulze
Modified: 2013-02-15 23:27 PST (History)
5 users (show)

See Also:


Attachments
Patch (10.11 KB, patch)
2011-10-30 04:01 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2011-10-30 03:52:15 PDT
I'll move checkIntersection/checkEnclosure from RenderSVGModelObject to SVGRenderSupport. Both functions are not only related to RenderSVGModelObject and its subclasses, but to all SVG renderer. Therefor SVGRenderSupport is a better place.
Comment 1 Dirk Schulze 2011-10-30 04:01:54 PDT
Created attachment 112992 [details]
Patch
Comment 2 Nikolas Zimmermann 2011-10-30 06:48:18 PDT
Comment on attachment 112992 [details]
Patch

I think this is the wrong direction. We were trying to slowly kill SVGRenderSupport, remember?
Why not keep them in RenderSVGModelObject, after-all they are static there?