Bug 71178 – Add TrackEvent

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#trackevent defines the TrackEvent, needed for the TextTrack 'addtrack' event.

[Radar WebKit Bug Importer]

<rdar://problem/10367475>

[Eric Carlson]

Created attachment 113208 [details]
Patch

Preliminary patch so the EWS bots can point out any obvious problems.

[WebKit Review Bot]

Attachment 113208 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/html/track/TrackBase.h:26:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp:41:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp:48:  track_event is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 4 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Gustavo Noronha (kov)]

Comment on attachment 113208 [details]
Patch

Attachment 113208 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10128379

[Early Warning System Bot]

Comment on attachment 113208 [details]
Patch

Attachment 113208 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10148035

[Eric Carlson]

(In reply to comment #5)
> (From update of attachment 113208 [details])
> Attachment 113208 [details] did not pass qt-ews (qt):
> Output: http://queues.webkit.org/results/10148035

Oops, I forgot to surround the TrackEvent initialization constructor in EventConstructors.h with "#if ENABLE(VIDEO_TRACK)"

[WebKit Review Bot]

Comment on attachment 113208 [details]
Patch

Attachment 113208 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10257045

[Sam Weinig]

Comment on attachment 113208 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113208&action=review

> Source/WebCore/bindings/generic/EventConstructors.h:142
> +#define INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_TRACK_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY) \
> +    \
> +    DICTIONARY_START(TrackEvent) \
> +        FILL_PARENT_PROPERTIES(Event) \
> +        FILL_PROPERTY(track) \
> +    DICTIONARY_END(TrackEvent)

This probably needs #ifdefing.

[Eric Carlson]

(In reply to comment #8)
> (From update of attachment 113208 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=113208&action=review
> 
> > Source/WebCore/bindings/generic/EventConstructors.h:142
> > +#define INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_TRACK_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY) \
> > +    \
> > +    DICTIONARY_START(TrackEvent) \
> > +        FILL_PARENT_PROPERTIES(Event) \
> > +        FILL_PROPERTY(track) \
> > +    DICTIONARY_END(TrackEvent)
> 
> This probably needs #ifdefing.

See comment #6 ;-)

[Daniel Bates]

Comment on attachment 113208 [details]
Patch

Attachment 113208 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/10257115

[Eric Carlson]

Created attachment 113277 [details]
Updated patch

This patch is being uploaded so the EWS bots can see if it compiles. 

It is not marked for review so there is no need to mark it cq- if it fails to compile.

[WebKit Review Bot]

Attachment 113277 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/html/track/TrackBase.h:26:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp:41:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp:48:  track_event is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 3 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 113277 [details]
Updated patch

Attachment 113277 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10148134

[WebKit Review Bot]

Comment on attachment 113277 [details]
Updated patch

Attachment 113277 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10257169

[Collabora GTK+ EWS bot]

Comment on attachment 113277 [details]
Updated patch

Attachment 113277 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10259213

[Eric Carlson]

Created attachment 113323 [details]
Yet another patch for the EWS bots to chew up and spit out.

[WebKit Review Bot]

Attachment 113323 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/html/track/TrackBase.h:26:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp:41:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp:48:  track_event is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 3 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Collabora GTK+ EWS bot]

Comment on attachment 113323 [details]
Yet another patch for the EWS bots to chew up and spit out.

Attachment 113323 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10258293

[WebKit Review Bot]

Comment on attachment 113323 [details]
Yet another patch for the EWS bots to chew up and spit out.

Attachment 113323 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10256315

[Eric Carlson]

Created attachment 113344 [details]
Updated patch

This should build on GTK thanks to Philippe Normand.

[WebKit Review Bot]

Attachment 113344 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp:47:  track_event is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 42 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 113344 [details]
Updated patch

Attachment 113344 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10128682

[Eric Carlson]

Created attachment 113381 [details]
Another patch

This should compile, lets see if it links.

[WebKit Review Bot]

Attachment 113381 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp:47:  track_event is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 42 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Carlson]

Created attachment 113386 [details]
Another patch, hopefully the right version this time.

[WebKit Review Bot]

Comment on attachment 113386 [details]
Another patch, hopefully the right version this time.

Attachment 113386 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10175412

[Eric Carlson]

Created attachment 113489 [details]
This might be the one.

[Sam Weinig]

Comment on attachment 113489 [details]
This might be the one.

View in context: https://bugs.webkit.org/attachment.cgi?id=113489&action=review

> Source/WebCore/html/track/TrackEvent.h:64
> +    virtual bool isTrackEvent() const { return true; }

This is no longer needed.

[Eric Carlson]

http://trac.webkit.org/changeset/99261