Bug 71169 - DOMURL should keep its own state rather than storing it on ScriptExecutionContext
Summary: DOMURL should keep its own state rather than storing it on ScriptExecutionCon...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-28 18:42 PDT by Adam Barth
Modified: 2011-10-30 22:32 PDT (History)
3 users (show)

See Also:


Attachments
Patch (10.29 KB, patch)
2011-10-28 18:44 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (10.28 KB, patch)
2011-10-29 00:51 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-10-28 18:42:39 PDT
DOMURL should keep its own state rather than storing it on ScriptExecutionContext
Comment 1 Adam Barth 2011-10-28 18:44:32 PDT
Created attachment 112961 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-10-28 21:41:24 PDT
Comment on attachment 112961 [details]
Patch

Makes sense to me.
Comment 3 WebKit Review Bot 2011-10-28 22:29:11 PDT
Comment on attachment 112961 [details]
Patch

Rejecting attachment 112961 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
:String&)':
Source/WebCore/html/DOMURL.cpp:120: error: 'isMainThread' was not declared in this scope
make: *** [out/Debug/obj.target/webcore_html/Source/WebCore/html/DOMURL.o] Error 1
make: *** Waiting for unfinished jobs....

Failed to run "['Tools/Scripts/build-webkit', '--debug', '--chromium', '--update-chromium']" exit_code: 2
ainThread' was not declared in this scope
make: *** [out/Debug/obj.target/webcore_html/Source/WebCore/html/DOMURL.o] Error 1
make: *** Waiting for unfinished jobs....

Full output: http://queues.webkit.org/results/10242263
Comment 4 Adam Barth 2011-10-29 00:51:34 PDT
Created attachment 112967 [details]
Patch for landing
Comment 5 WebKit Review Bot 2011-10-29 02:10:48 PDT
Comment on attachment 112967 [details]
Patch for landing

Clearing flags on attachment: 112967

Committed r98802: <http://trac.webkit.org/changeset/98802>
Comment 6 WebKit Review Bot 2011-10-29 02:10:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Alexey Proskuryakov 2011-10-30 22:28:23 PDT
Comment on attachment 112967 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=112967&action=review

> Source/WebCore/html/DOMURL.cpp:66
> +    for (HashSet<String>::iterator iter = m_publicStreamURLs.begin(); iter != publicStreamURLsEnd; ++iter)
> +        MediaStreamRegistry::registry().unregisterMediaStreamURL(KURL(ParsedURLString, *iter));

It's going to ASSERT(isMainThread()). Is DOMURL really main thread only (and why does it have NoStaticTables in IDL in that case)?
Comment 8 Adam Barth 2011-10-30 22:32:06 PDT
This patch doesn't change anything about how this code works.  You probably want to file a new bug and CC the person who added the ASSERT.