Some of the virtual functions that return a LayoutRect still have overridden versions that return an IntRect. Specifically the following methods: controlClipRect windowResizerRect windowClipRect visibleContentRect scrollCornerRect outlineBoundsForRepaint localCaretRect
Created attachment 112954 [details] Patch
Comment on attachment 112954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112954&action=review > Source/WebCore/page/FrameView.cpp:2312 > -LayoutRect FrameView::windowClipRect(bool clipToContents) const > +IntRect FrameView::windowClipRect(bool clipToContents) const Why going back?
(In reply to comment #2) > (From update of attachment 112954 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=112954&action=review > > > Source/WebCore/page/FrameView.cpp:2312 > > -LayoutRect FrameView::windowClipRect(bool clipToContents) const > > +IntRect FrameView::windowClipRect(bool clipToContents) const > > Why going back? We're keeping certain things as ints to ensure alignment, specifically window coordinates and sizes as well as scroll offsets.
Comment on attachment 112954 [details] Patch Clearing flags on attachment: 112954 Committed r98883: <http://trac.webkit.org/changeset/98883>
All reviewed patches have been landed. Closing bug.