Bug 71166 - Overridden LayoutRect method still uses IntRects
Summary: Overridden LayoutRect method still uses IntRects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-28 17:50 PDT by Emil A Eklund
Modified: 2011-10-31 14:33 PDT (History)
4 users (show)

See Also:


Attachments
Patch (17.03 KB, patch)
2011-10-28 17:57 PDT, Emil A Eklund
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2011-10-28 17:50:27 PDT
Some of the virtual functions that return a LayoutRect still have overridden versions that return an IntRect. Specifically the following methods:

controlClipRect
windowResizerRect
windowClipRect
visibleContentRect
scrollCornerRect
outlineBoundsForRepaint
localCaretRect
Comment 1 Emil A Eklund 2011-10-28 17:57:50 PDT
Created attachment 112954 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-10-28 21:42:15 PDT
Comment on attachment 112954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112954&action=review

> Source/WebCore/page/FrameView.cpp:2312
> -LayoutRect FrameView::windowClipRect(bool clipToContents) const
> +IntRect FrameView::windowClipRect(bool clipToContents) const

Why going back?
Comment 3 Emil A Eklund 2011-10-31 10:13:15 PDT
(In reply to comment #2)
> (From update of attachment 112954 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=112954&action=review
> 
> > Source/WebCore/page/FrameView.cpp:2312
> > -LayoutRect FrameView::windowClipRect(bool clipToContents) const
> > +IntRect FrameView::windowClipRect(bool clipToContents) const
> 
> Why going back?

We're keeping certain things as ints to ensure alignment, specifically window coordinates and sizes as well as scroll offsets.
Comment 4 WebKit Review Bot 2011-10-31 14:33:53 PDT
Comment on attachment 112954 [details]
Patch

Clearing flags on attachment: 112954

Committed r98883: <http://trac.webkit.org/changeset/98883>
Comment 5 WebKit Review Bot 2011-10-31 14:33:58 PDT
All reviewed patches have been landed.  Closing bug.