Overflow and relayout are broken in the new flexboxes
Created attachment 112943 [details] Patch
Comment on attachment 112943 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112943&action=review > Source/WebCore/rendering/RenderFlexibleBox.cpp:683 > + bool shouldFlipMainAxis = isColumnFlow() ? false : !isLeftToRightFlow(); Nit: This may read easier as isHorizontalFlow() && !isLeftToRightFlow().
(In reply to comment #2) > (From update of attachment 112943 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=112943&action=review > > > Source/WebCore/rendering/RenderFlexibleBox.cpp:683 > > + bool shouldFlipMainAxis = isColumnFlow() ? false : !isLeftToRightFlow(); > > Nit: This may read easier as isHorizontalFlow() && !isLeftToRightFlow(). This isn't actually equivalent, e.g. this would return true for flex-flow:column + writing-mode:horizontal-tb but the above always returns false for flex-flow:column. I guess I should rewrite it as: !isColumnFlow() && !isLeftToRightFlow().
Created attachment 113547 [details] Patch
Comment on attachment 113547 [details] Patch r=me
Committed r100324: <http://trac.webkit.org/changeset/100324>
Ojan, it looks like css3/flexbox/repaint-rtl-column.html, for which you added a Snow Leopard expected result, is also failing on Win/Linux (see http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=css3%2Fflexbox%2Frepaint-rtl-column.html ). Should this just be rebaselined?
Yup. Rebaselining now.