Bug 71160 – NRWT doesn't show build output when building DRT

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Simon Fraser (smfr)]

4$ $ ./Tools/Scripts/run-webkit-tests --debug LayoutTests/canvas/
Running new-run-webkit-tests with one child process.
For more parallelism, run new-run-webkit-tests directly.
Failed to build DumpRenderTree
Build check failed

Not very helpful.



 6$ $ ./Tools/Scripts/old-run-webkit-tests --debug LayoutTests/canvas/
Running build-dumprendertree
2011-10-28 16:29:42.789 xcodebuild[513:60f] [MT] DVTPlugInManager: Error obtaining required capabilities for GPUDebuggerFoundation.ideplugin: Error Domain=NSCocoaErrorDomain Code=260 UserInfo=0x2002da6c0 "The file “Info.plist” couldn’t be opened because there is no such file." Underlying Error=(Error Domain=NSPOSIXErrorDomain Code=2 "The operation couldn’t be completed. No such file or directory")
2011-10-28 16:29:42.803 xcodebuild[513:60f] [MT] DVTPlugInManager: Error obtaining required capabilities for GPUTraceDebugger.ideplugin: Error Domain=NSCocoaErrorDomain Code=260 UserInfo=0x20034f5e0 "The file “Info.plist” couldn’t be opened because there is no such file." Underlying Error=(Error Domain=NSPOSIXErrorDomain Code=2 "The operation couldn’t be completed. No such file or directory")
Build settings from command line:
    ARCHS = x86_64
    OBJROOT = /Users/smfr/webkit/WebKit.git/WebKitBuild
    SYMROOT = /Users/smfr/webkit/WebKit.git/WebKitBuild

=== BUILD NATIVE TARGET DumpRenderTree OF PROJECT DumpRenderTree WITH CONFIGURATION Debug ===
Check dependencies


=== BUILD NATIVE TARGET ImageDiff OF PROJECT DumpRenderTree WITH CONFIGURATION Debug ===
Check dependencies


=== BUILD NATIVE TARGET TestNetscapePlugIn OF PROJECT DumpRenderTree WITH CONFIGURATION Debug ===
Check dependencies

CompileC /Users/smfr/webkit/WebKit.git/WebKitBuild/DumpRenderTree.build/Debug/TestNetscapePlugIn.build/Objects-normal/x86_64/ContentsScaleFactor.o TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
    cd /Users/smfr/webkit/WebKit.git/Tools/DumpRenderTree
    setenv LANG en_US.US-ASCII
    /Developer/usr/bin/clang -x c++ -arch x86_64 -fmessage-length=0 -fdiagnostics-print-source-range-info -fdiagnostics-show-category=id -fdiagnostics-parseable-fixits -Wno-trigraphs -fpascal-strings -O0 -Werror -Wno-return-type -Wparentheses -Wswitch -Wunused-function -Wno-unused-parameter -Wunused-variable -Wunused-value -Wno-shorten-64-to-32 -Wc++0x-extensions -DENABLE_DASHBOARD_SUPPORT -DWEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST -fasm-blocks -Wno-deprecated-declarations -mmacosx-version-min=10.6 -gdwarf-2 -fvisibility-inlines-hidden -Wno-sign-conversion -I/Users/smfr/webkit/WebKit.git/WebKitBuild/DumpRenderTree.build/Debug/TestNetscapePlugIn.build/TestNetscapePlugIn.hmap -I/Users/smfr/webkit/WebKit.git/WebKitBuild/Debug/include -IForwardingHeaders -Imac/InternalHeaders -I/usr/local/include/WebCoreTestSupport -I/Users/smfr/webkit/WebKit.git/WebKitBuild/DumpRenderTree.build/Debug/TestNetscapePlugIn.build/DerivedSources/x86_64 -I/Users/smfr/webkit/WebKit.git/WebKitBuild/DumpRenderTree.build/Debug/TestNetscapePlugIn.build/DerivedSources -Wmost -Wno-four-char-constants -Wno-unknown-pragmas -F/Users/smfr/webkit/WebKit.git/WebKitBuild/Debug -F/System/Library/Frameworks/Quartz.framework/Frameworks -F/System/Library/Frameworks/ApplicationServices.framework/Frameworks -F/System/Library/Frameworks/CoreServices.framework/Frameworks -MMD -MT dependencies -MF /Users/smfr/webkit/WebKit.git/WebKitBuild/DumpRenderTree.build/Debug/TestNetscapePlugIn.build/Objects-normal/x86_64/ContentsScaleFactor.d -c /Users/smfr/webkit/WebKit.git/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp -o /Users/smfr/webkit/WebKit.git/WebKitBuild/DumpRenderTree.build/Debug/TestNetscapePlugIn.build/Objects-normal/x86_64/ContentsScaleFactor.o
/Users/smfr/webkit/WebKit.git/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp:42:22: error: use of undeclared identifier 'NPNVcontentsScaleFactor'; did you mean 'contentsScaleFactor'? [3]
         NPN_GetValue(NPNVcontentsScaleFactor, &contentsScaleFactor);
                      ^~~~~~~~~~~~~~~~~~~~~~~
                      contentsScaleFactor
fix-it:"/Users/smfr/webkit/WebKit.git/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp":{42:22-42:45}:"contentsScaleFactor"
/Users/smfr/webkit/WebKit.git/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp:41:16: note: 'contentsScaleFactor' declared here [3]
         double contentsScaleFactor = 1.0;
                ^
/Users/smfr/webkit/WebKit.git/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp:42:22:{42:22-42:45}: error: cannot initialize a parameter of type 'NPNVariable' with an lvalue of type 'double' [3]
         NPN_GetValue(NPNVcontentsScaleFactor, &contentsScaleFactor);
                      ^~~~~~~~~~~~~~~~~~~~~~~
/Users/smfr/webkit/WebKit.git/Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.h:77:37: note: passing argument to parameter here [3]
     NPError NPN_GetValue(NPNVariable, void* value);
                                     ^
/Users/smfr/webkit/WebKit.git/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp:97:14: error: use of undeclared identifier 'NPNVcontentsScaleFactor'; did you mean 'contentsScaleFactor'? [3]
         case NPNVcontentsScaleFactor:
              ^~~~~~~~~~~~~~~~~~~~~~~
              contentsScaleFactor
fix-it:"/Users/smfr/webkit/WebKit.git/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp":{97:14-97:37}:"contentsScaleFactor"
/Users/smfr/webkit/WebKit.git/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp:41:16: note: 'contentsScaleFactor' declared here [3]
         double contentsScaleFactor = 1.0;
                ^
/Users/smfr/webkit/WebKit.git/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp:97:14:{97:14-97:37}: error: expression is not an integer constant expression [3]
         case NPNVcontentsScaleFactor:
              ^~~~~~~~~~~~~~~~~~~~~~~
4 errors generated.


** BUILD FAILED **


The following build commands failed:
	CompileC /Users/smfr/webkit/WebKit.git/WebKitBuild/DumpRenderTree.build/Debug/TestNetscapePlugIn.build/Objects-normal/x86_64/ContentsScaleFactor.o TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
Compiling DumpRenderTree failed!

More helpful.

[Eric Seidel (no email)]

The behavior is intentional.  It could save the log somewhere, or it could direct you to use build-dumprendertree to debug the failure,or print the output if passed --verbose.  NRWT is intentionally much more sparse in output than ORWT.

Keeping with the "show the minimum needed for the common case" philosophy, do you have a preference between telling folks to debug with build-dumprendertree, or pass --verbose, or spewing the log only on failure?

[Simon Fraser (smfr)]

Spew the log only on failure. It needs to show up on the bots too.

[Adam Roben (:aroben)]

I'd recommend spewing when --verbose is passed or when the build fails, even if --verbose was not passed.

It would be great to fix this so we can investigate bug 73326.

[Adam Roben (:aroben)]

I'm going to take a stab at this.

[Adam Roben (:aroben)]

Created attachment 117227 [details]
Make NRWT show DRT/WTR build logs when the build fails or --verbose is passed

[Eric Seidel (no email)]

Comment on attachment 117227 [details]
Make NRWT show DRT/WTR build logs when the build fails or --verbose is passed

LGTM.  Thanks!

[Adam Roben (:aroben)]

Committed r101534: <http://trac.webkit.org/changeset/101534>