Bug 71154 - webkit.py gdb visualizer is broken after change to StringImpl
Summary: webkit.py gdb visualizer is broken after change to StringImpl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rafael Weinstein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-28 15:53 PDT by Rafael Weinstein
Modified: 2011-10-28 17:04 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.53 KB, patch)
2011-10-28 15:56 PDT, Rafael Weinstein
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Weinstein 2011-10-28 15:53:18 PDT
StringImpl's m_data is now m_data16. Change webkit.py to match.
Comment 1 Rafael Weinstein 2011-10-28 15:56:56 PDT
Created attachment 112929 [details]
Patch
Comment 2 Rafael Weinstein 2011-10-28 15:58:07 PDT
BTW, I've never touched this file before and know almost no python. I'm just guessing that both WTFString & JSCUString need to be changed. Please verify that this is right.
Comment 3 WebKit Review Bot 2011-10-28 17:04:01 PDT
Comment on attachment 112929 [details]
Patch

Clearing flags on attachment: 112929

Committed r98785: <http://trac.webkit.org/changeset/98785>
Comment 4 WebKit Review Bot 2011-10-28 17:04:05 PDT
All reviewed patches have been landed.  Closing bug.