Bug 71151 - Rename DataTransferItems to DataTransferItemList
Summary: Rename DataTransferItems to DataTransferItemList
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Cheng
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-28 15:30 PDT by Daniel Cheng
Modified: 2011-10-29 16:28 PDT (History)
4 users (show)

See Also:


Attachments
Patch (57.31 KB, patch)
2011-10-28 15:31 PDT, Daniel Cheng
no flags Details | Formatted Diff | Diff
Patch (61.33 KB, patch)
2011-10-28 15:57 PDT, Daniel Cheng
no flags Details | Formatted Diff | Diff
Patch (61.59 KB, patch)
2011-10-28 16:14 PDT, Daniel Cheng
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Cheng 2011-10-28 15:30:26 PDT
Rename DataTransferItems to DataTransferItemList
Comment 1 Daniel Cheng 2011-10-28 15:31:09 PDT
Created attachment 112922 [details]
Patch
Comment 2 WebKit Review Bot 2011-10-28 15:33:38 PDT
Attachment 112922 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/dom/Clipboard.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2011-10-28 15:43:21 PDT
Comment on attachment 112922 [details]
Patch

Attachment 112922 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10244052
Comment 4 Daniel Cheng 2011-10-28 15:57:38 PDT
Created attachment 112931 [details]
Patch
Comment 5 WebKit Review Bot 2011-10-28 16:01:48 PDT
Attachment 112931 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1

Source/WebCore/dom/Clipboard.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Tony Chang 2011-10-28 16:04:09 PDT
Comment on attachment 112931 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112931&action=review

> Source/WebCore/ChangeLog:4
> +        Rename DataTransferItems to DataTransferItemList
> +        https://bugs.webkit.org/show_bug.cgi?id=71151

Do you have a link to where this rename happened?
Comment 7 Daniel Cheng 2011-10-28 16:14:03 PDT
Created attachment 112937 [details]
Patch
Comment 8 Daniel Cheng 2011-10-28 16:14:23 PDT
Comment on attachment 112931 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112931&action=review

>> Source/WebCore/ChangeLog:4
>> +        https://bugs.webkit.org/show_bug.cgi?id=71151
> 
> Do you have a link to where this rename happened?

Added a link to the spec with a little context.
Comment 9 WebKit Review Bot 2011-10-28 16:16:31 PDT
Attachment 112937 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1

Source/WebCore/dom/Clipboard.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Tony Chang 2011-10-28 16:18:42 PDT
Comment on attachment 112937 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112937&action=review

Please make sure that the ews bots all compile before landing.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:1767
> -		781755861365A1B00093BE2E /* DataTransferItems.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 781755851365A1B00093BE2E /* DataTransferItems.cpp */; };
> +		781755861365A1B00093BE2E /* DataTransferItemList.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 781755851365A1B00093BE2E /* DataTransferItemList.cpp */; };

Did you actually open these in xcode?  I think the hash will change because the filename changed . . .
Comment 11 Daniel Bates 2011-10-29 01:18:17 PDT
Comment on attachment 112937 [details]
Patch

Attachment 112937 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/10241309
Comment 12 Daniel Cheng 2011-10-29 15:53:41 PDT
Comment on attachment 112937 [details]
Patch

Patched it into a clean tree on Mac and it worked for me.
Comment 13 WebKit Review Bot 2011-10-29 16:27:58 PDT
Comment on attachment 112937 [details]
Patch

Clearing flags on attachment: 112937

Committed r98821: <http://trac.webkit.org/changeset/98821>
Comment 14 WebKit Review Bot 2011-10-29 16:28:04 PDT
All reviewed patches have been landed.  Closing bug.