Bug 71146 - De-virtualize JSObject::defaultValue
Summary: De-virtualize JSObject::defaultValue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks: 70960
  Show dependency treegraph
 
Reported: 2011-10-28 15:04 PDT by Mark Hahnenberg
Modified: 2011-10-31 18:15 PDT (History)
1 user (show)

See Also:


Attachments
Patch (18.62 KB, patch)
2011-10-28 15:40 PDT, Mark Hahnenberg
sam: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2011-10-28 15:04:45 PDT
We're de-virtualizing JSObject. defaultValue is a virtual method in JSObject.  Thus, we need to de-virtualize defaultValue.  We'll put it in the MethodTable.
Comment 1 Mark Hahnenberg 2011-10-28 15:40:49 PDT
Created attachment 112926 [details]
Patch
Comment 2 WebKit Review Bot 2011-10-31 15:32:37 PDT
Comment on attachment 112926 [details]
Patch

Rejecting attachment 112926 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
g file Source/JavaScriptCore/runtime/JSObject.cpp
patching file Source/JavaScriptCore/runtime/JSObject.h
patching file Source/WebCore/WebCore.exp.in
patching file Source/WebCore/bridge/objc/objc_runtime.h
patching file Source/WebCore/bridge/objc/objc_runtime.mm
patching file Source/WebCore/bridge/runtime_object.cpp
patching file Source/WebCore/bridge/runtime_object.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Sam Weinig', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/10249110
Comment 3 Mark Hahnenberg 2011-10-31 18:15:19 PDT
Committed r98932: <http://trac.webkit.org/changeset/98932>