WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
71146
De-virtualize JSObject::defaultValue
https://bugs.webkit.org/show_bug.cgi?id=71146
Summary
De-virtualize JSObject::defaultValue
Mark Hahnenberg
Reported
2011-10-28 15:04:45 PDT
We're de-virtualizing JSObject. defaultValue is a virtual method in JSObject. Thus, we need to de-virtualize defaultValue. We'll put it in the MethodTable.
Attachments
Patch
(18.62 KB, patch)
2011-10-28 15:40 PDT
,
Mark Hahnenberg
sam
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1
2011-10-28 15:40:49 PDT
Created
attachment 112926
[details]
Patch
WebKit Review Bot
Comment 2
2011-10-31 15:32:37 PDT
Comment on
attachment 112926
[details]
Patch Rejecting
attachment 112926
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: g file Source/JavaScriptCore/runtime/JSObject.cpp patching file Source/JavaScriptCore/runtime/JSObject.h patching file Source/WebCore/WebCore.exp.in patching file Source/WebCore/bridge/objc/objc_runtime.h patching file Source/WebCore/bridge/objc/objc_runtime.mm patching file Source/WebCore/bridge/runtime_object.cpp patching file Source/WebCore/bridge/runtime_object.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Sam Weinig', u'--force']" exit_code: 1 Full output:
http://queues.webkit.org/results/10249110
Mark Hahnenberg
Comment 3
2011-10-31 18:15:19 PDT
Committed
r98932
: <
http://trac.webkit.org/changeset/98932
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug