Bug 71134 – De-virtualize JSObject::defineGetter

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Hahnenberg]

We're de-virtualizing JSObject. defineGetter is a virtual method in JSObject.  Thus, we need to de-virtualize defineGetter.  We'll put it in the MethodTable.

[Mark Hahnenberg]

Created attachment 112902 [details]
Patch

[Darin Adler]

Comment on attachment 112902 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112902&action=review

> Source/WebKit/qt/Api/qwebframe.cpp:517
> -    window->defineGetter(exec, propertyName.get()->identifier(&exec->globalData()), ::toJS(function),
> +    window->methodTable()->defineGetter(window, exec, propertyName.get()->identifier(&exec->globalData()), ::toJS(function),
>                           JSC::ReadOnly | JSC::DontEnum | JSC::DontDelete);

Not to everyone on the project: Here is an example of why we don’t line up subsequent lines of multiline statements.

[WebKit Review Bot]

Comment on attachment 112902 [details]
Patch

Clearing flags on attachment: 112902

Committed r98889: <http://trac.webkit.org/changeset/98889>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

It broke the interpreter build. Build log from Qt SH4 buildbot:

../../../Source/JavaScriptCore/interpreter/Interpreter.cpp:4992:115: error: too few arguments to function

Could you fix the build please?

[Csaba Osztrogonác]

(In reply to comment #5)
> It broke the interpreter build. Build log from Qt SH4 buildbot:
> 
> ../../../Source/JavaScriptCore/interpreter/Interpreter.cpp:4992:115: error: too few arguments to function
> 
> Could you fix the build please?

Buildfix landed in http://trac.webkit.org/changeset/98916