We're de-virtualizing JSObject. defineGetter is a virtual method in JSObject. Thus, we need to de-virtualize defineGetter. We'll put it in the MethodTable.
Created attachment 112902 [details] Patch
Comment on attachment 112902 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112902&action=review > Source/WebKit/qt/Api/qwebframe.cpp:517 > - window->defineGetter(exec, propertyName.get()->identifier(&exec->globalData()), ::toJS(function), > + window->methodTable()->defineGetter(window, exec, propertyName.get()->identifier(&exec->globalData()), ::toJS(function), > JSC::ReadOnly | JSC::DontEnum | JSC::DontDelete); Not to everyone on the project: Here is an example of why we don’t line up subsequent lines of multiline statements.
Comment on attachment 112902 [details] Patch Clearing flags on attachment: 112902 Committed r98889: <http://trac.webkit.org/changeset/98889>
All reviewed patches have been landed. Closing bug.
It broke the interpreter build. Build log from Qt SH4 buildbot: ../../../Source/JavaScriptCore/interpreter/Interpreter.cpp:4992:115: error: too few arguments to function Could you fix the build please?
(In reply to comment #5) > It broke the interpreter build. Build log from Qt SH4 buildbot: > > ../../../Source/JavaScriptCore/interpreter/Interpreter.cpp:4992:115: error: too few arguments to function > > Could you fix the build please? Buildfix landed in http://trac.webkit.org/changeset/98916