Bug 71129 - IndexedDB: IDBDatabase should have a close pending field.
Summary: IndexedDB: IDBDatabase should have a close pending field.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-28 12:01 PDT by jochen
Modified: 2012-06-28 16:48 PDT (History)
6 users (show)

See Also:


Attachments
Patch (15.55 KB, patch)
2012-06-28 11:17 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2011-10-28 12:01:47 PDT
IDBDatabase should have a close pending field, and nobody should send versionchange events to it while it's closing (see also http://code.google.com/p/chromium/issues/detail?id=100645)
Comment 1 Joshua Bell 2012-06-28 11:17:48 PDT
Created attachment 149976 [details]
Patch
Comment 2 Joshua Bell 2012-06-28 11:18:57 PDT
alecflett@ - can you take a look?

tony@ - r?
Comment 3 Joshua Bell 2012-06-28 11:27:04 PDT
Note that most chunks of the new layout test passed before and are redundant with other tests, but I wanted everything that exercised the flag in one place.

The bits that previously failed were the version change and delete, which exercise the case described in the ChangeLog.
Comment 4 Alec Flett 2012-06-28 15:47:32 PDT
Comment on attachment 149976 [details]
Patch

LGTM
Comment 5 WebKit Review Bot 2012-06-28 16:48:49 PDT
Comment on attachment 149976 [details]
Patch

Clearing flags on attachment: 149976

Committed r121488: <http://trac.webkit.org/changeset/121488>
Comment 6 WebKit Review Bot 2012-06-28 16:48:54 PDT
All reviewed patches have been landed.  Closing bug.