Bug 71117 – [Qt] REGRESSION: 5 editing tests fail

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

After Qt5 updating on the WK2 bot, there are 5 new failing test:
editing/deleting/merge-paragraph-from-p-with-style-2.html
editing/deleting/merge-paragraph-from-p-with-style-3.html
editing/deleting/merge-paragraph-into-h1-with-dir-2.html
editing/deleting/merge-paragraph-into-h1-with-dir.html
editing/deleting/merge-paragraph-from-h6-with-style-2.html

Qt5 version before updating: https://lists.webkit.org/pipermail/webkit-qt/2011-October/002035.html
Qt5 version after updating: https://lists.webkit.org/pipermail/webkit-qt/2011-October/002053.html

It might be regression come from Qt5 update or might be a regression come from WebKit 
trunk between 98716-98723. I tested them with Qt5 and QtWebKit - WebKit1 and all of 
them passed. So it is a Qt5 and WK2 related bug.

[Csaba Osztrogonác]

(In reply to comment #0)
> It might be regression come from Qt5 update or might be a regression come from WebKit 
> trunk between 98716-98723. I tested them with Qt5 and QtWebKit - WebKit1 and all of 
> them passed. So it is a Qt5 and WK2 related bug.

These tests fail on 98716 too, so it is a Qt5 regression.

[Csaba Osztrogonác]

Here are the diffs:


--- /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/editing/deleting/merge-paragraph-from-p-with-style-2-expected.txt 
+++ /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/editing/deleting/merge-paragraph-from-p-with-style-2-actual.txt 
@@ -1,12 +1,9 @@
-EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 5 of DIV > BODY > HTML > #document
-EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: shouldDeleteDOMRange:range from 5 of #text > H1 > DIV > BODY > HTML > #document to 0 of P > DIV > BODY > HTML > #document
 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 2 of DIV > BODY > HTML > #document to 2 of DIV > BODY > HTML > #document toDOMRange:range from 5 of #text > H1 > DIV > BODY > HTML > #document to 5 of #text > H1 > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: webViewDidEndEditing:WebViewDidEndEditingNotification
 This tests deleting line break before p.
 WebKit should not keep the style of p added by a style rule, and "world" should be italic and not be in red.
 | "


--- /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/editing/deleting/merge-paragraph-from-p-with-style-3-expected.txt 
+++ /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/editing/deleting/merge-paragraph-from-p-with-style-3-actual.txt 
@@ -1,12 +1,9 @@
-EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 5 of DIV > BODY > HTML > #document
-EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: shouldDeleteDOMRange:range from 5 of #text > H1 > DIV > BODY > HTML > #document to 0 of P > DIV > BODY > HTML > #document
 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 2 of DIV > BODY > HTML > #document to 2 of DIV > BODY > HTML > #document toDOMRange:range from 5 of #text > H1 > DIV > BODY > HTML > #document to 5 of #text > H1 > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: webViewDidEndEditing:WebViewDidEndEditingNotification
 This tests deleting line break before p.
 WebKit preserves the inline style of the merged paragraph, and "world" should be in green.
 | "



--- /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/editing/deleting/merge-paragraph-into-h1-with-dir-2-expected.txt 
+++ /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/editing/deleting/merge-paragraph-into-h1-with-dir-2-actual.txt 
@@ -1,12 +1,9 @@
-EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 5 of DIV > BODY > HTML > #document
-EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: shouldDeleteDOMRange:range from 5 of #text > H1 > DIV > BODY > HTML > #document to 0 of P > DIV > BODY > HTML > #document
 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 2 of DIV > BODY > HTML > #document to 2 of DIV > BODY > HTML > #document toDOMRange:range from 5 of #text > H1 > DIV > BODY > HTML > #document to 5 of #text > H1 > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: webViewDidEndEditing:WebViewDidEndEditingNotification
 This tests deleting line break after h1 inside a block with dir attribute.
 WebKit should not add direction or unicode-bidi properties while merging paragraphs.
 | "



--- /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/editing/deleting/merge-paragraph-into-h1-with-dir-expected.txt 
+++ /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/editing/deleting/merge-paragraph-into-h1-with-dir-actual.txt 
@@ -1,12 +1,9 @@
-EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 5 of DIV > BODY > HTML > #document
-EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: shouldDeleteDOMRange:range from 5 of #text > H1 > DIV > BODY > HTML > #document to 0 of P > DIV > BODY > HTML > #document
 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 2 of DIV > BODY > HTML > #document to 2 of DIV > BODY > HTML > #document toDOMRange:range from 5 of #text > H1 > DIV > BODY > HTML > #document to 5 of #text > H1 > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: webViewDidEndEditing:WebViewDidEndEditingNotification
 This tests deleting line break after h1 inside a block with dir attribute.
 WebKit should not add direction or unicode-bidi properties while merging paragraphs.
 | "

--- /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/editing/deleting/merge-paragraph-from-h6-with-style-2-expected.txt 
+++ /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/editing/deleting/merge-paragraph-from-h6-with-style-2-actual.txt 
@@ -1,12 +1,9 @@
-EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 5 of DIV > BODY > HTML > #document
-EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: shouldDeleteDOMRange:range from 1 of #text > DIV > BODY > HTML > #document to 0 of H6 > DIV > BODY > HTML > #document
 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 5 of #text > EM > DIV > BODY > HTML > #document to 5 of #text > EM > DIV > BODY > HTML > #document toDOMRange:range from 5 of #text > EM > DIV > BODY > HTML > #document to 5 of #text > EM > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: webViewDidEndEditing:WebViewDidEndEditingNotification
 This tests deleting line break before h6.
 WebKit should not cancel styles added by h6 by those of document's default style but still keep "hello" italicized and "world" in red.
 | "

[Simon Hausmann]

I suspect that this is related to focus handling. It seems to me that didBeginEditing is called when the focus is transferred to an editable element. It could be that something changed with the focus handling in Qt not causing the view/widget to receive the focus the way it did before.

[Csaba Osztrogonác]

I skipped them to make bot happier : http://trac.webkit.org/changeset/98726

[Simon Hausmann]

Created attachment 113328 [details]
[Qt] REGRESSION: 5 editing tests fail

[Andreas Kling]

Comment on attachment 113328 [details]
[Qt] REGRESSION: 5 editing tests fail

r=me

[Simon Hausmann]

Comment on attachment 113328 [details]
[Qt] REGRESSION: 5 editing tests fail

Clearing flags on attachment: 113328

Committed r99081: <http://trac.webkit.org/changeset/99081>

[Simon Hausmann]

All reviewed patches have been landed.  Closing bug.