Bug 71114 – Web Inspector: do not map scripts generated with document.write to the document resources.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Patch to follow.

[Pavel Feldman]

Created attachment 112871 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 112871 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112871&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:116
> +        if (script.sourceURL && script.lineOffset !== 0 && script.columnOffset !== 0) {

Can we extract "script.lineOffset !== 0 && script.columnOffset !== 0" into script.isInlineScript() or something? It is used quite often in that sense.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:146
> +        this._rawSourceCode[script.scriptId] = rawSourceCode;

_rawSourceCode -> _rawSourceCodeForScriptId?

> Source/WebCore/inspector/front-end/Script.js:35
> +  */

Revert this.

> Source/WebCore/inspector/front-end/Script.js:47
> +WebInspector.Script._lastScriptId = 0;

Remove this?

> LayoutTests/inspector/debugger/bind-script-to-resource.html:55
> +Tests that only inline scripts are bound to the resource, while the ones generated with document.write are not. Bug 71099</a>

It is not clear at first glance what the correct result is which means that this test can be erroneously rebaselined should it start failing. Can you add an explicit check for the error condition and print FAIL in that case or describe here which result should be considered correct.

[Pavel Feldman]

Created attachment 113030 [details]
Patch

[Pavel Feldman]

Committed r98847: <http://trac.webkit.org/changeset/98847>

[Csaba Osztrogonác]

(In reply to comment #4)
> Committed r98847: <http://trac.webkit.org/changeset/98847>

It broke 3 inspector tests on Snow Leopard and on Qt bot:
inspector/debugger/bind-script-to-resource.html
inspector/debugger/linkifier.html
inspector/debugger/source-frame-count.html

Could you fix it please?

[Csaba Osztrogonác]

(In reply to comment #4)
> Committed r98847: <http://trac.webkit.org/changeset/98847>

It was rolled out by http://trac.webkit.org/changeset/98940

[Pavel Feldman]

Committed r99203: <http://trac.webkit.org/changeset/99203>

[Ryosuke Niwa]

It appears that this patch broke inspector/debugger/script-formatter.html

http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20(Tests)/builds/34424