[Qt][WK2] Move content to resize (setResizesToContentsUsingLayoutSize) from UI process to WebProcess
Created attachment 112847 [details] Patch
Comment on attachment 112847 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112847&action=review > Source/WebKit2/UIProcess/API/qt/qtouchwebview.cpp:118 > if (newGeometry.size() != oldGeometry.size()) { > + WebPageProxy* pageProxy = toImpl(d->page.pageRef()); > + // Let the WebProcess know about the new viewport size, so that > + // it can resize the content accordingly. > + pageProxy->setViewportSize(newGeometry.size().toSize()); > d->updateViewportConstraints(); Maybe we should make a d->updateViewportSize(...) method? Anyway the naming is inconsistent with the rest of the file: WebPageProxy* wkPage = toImpl(page.pageRef());
Created attachment 112855 [details] Patch
Comment on attachment 112855 [details] Patch updated patch based on Kenneth's comments.
Comment on attachment 112855 [details] Patch Rejecting attachment 112855 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ss/API/qt/qtouchwebview.cpp.rej patching file Source/WebKit2/UIProcess/API/qt/qtouchwebview_p.h patching file Source/WebKit2/UIProcess/qt/QtTouchWebPageProxy.cpp patching file Source/WebKit2/UIProcess/qt/QtTouchWebPageProxy.h patching file Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp patching file Source/WebKit2/WebProcess/WebPage/WebPage.messages.in Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christia..." exit_code: 1 Full output: http://queues.webkit.org/results/10241028
Created attachment 113308 [details] Patch
Comment on attachment 113308 [details] Patch Clearing flags on attachment: 113308 Committed r99058: <http://trac.webkit.org/changeset/99058>
All reviewed patches have been landed. Closing bug.