If you manually open http/tests/websocket/tests/{hixie76,hybi}/reload-crash.html from a browser, iframe in the test reloads repeatedly and the test doesn't stop even after finishJSTest() is called. My hypothesis is that this issue affects the subsequent tests and is the source of test flakiness of http://code.google.com/p/chromium/issues/detail?id=73094.
Created attachment 112837 [details] Patch
Comment on attachment 112837 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112837&action=review > LayoutTests/http/tests/websocket/tests/hixie76/reload-crash.html:26 > - return; > + return originalReloadCount; We can write "return 1;" > LayoutTests/http/tests/websocket/tests/hixie76/reload-crash.html:29 > reloadCount += 1; > + return originalReloadCount; We can write "return 0;" and can remove originalReloadCount.
Created attachment 112861 [details] Patch v2
Comment on attachment 112837 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112837&action=review >> LayoutTests/http/tests/websocket/tests/hixie76/reload-crash.html:26 >> + return originalReloadCount; > > We can write "return 1;" I rewrote the code around here; patch v2 should be much cleaner. originalReloadCount was removed.
Comment on attachment 112861 [details] Patch v2 Clearing flags on attachment: 112861 Committed r98835: <http://trac.webkit.org/changeset/98835>
All reviewed patches have been landed. Closing bug.