Bug 71089 - Web Inspector: Support using a different front-end in WebKit2
Summary: Web Inspector: Support using a different front-end in WebKit2
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
Keywords: InRadar
Depends on:
Reported: 2011-10-27 19:37 PDT by Timothy Hatcher
Modified: 2011-10-28 13:52 PDT (History)
8 users (show)

See Also:

Proposed Change (18.97 KB, patch)
2011-10-27 20:10 PDT, Timothy Hatcher
sam: review-
timothy: commit-queue-
Details | Formatted Diff | Diff
Proposed Change (round 2) (18.94 KB, patch)
2011-10-28 11:47 PDT, Timothy Hatcher
sam: review+
timothy: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2011-10-27 19:37:15 PDT
We need the ability to load a different front-end for debugging/testing purposes.

Comment 1 Timothy Hatcher 2011-10-27 20:10:15 PDT
Created attachment 112810 [details]
Proposed Change
Comment 2 Sam Weinig 2011-10-28 10:12:19 PDT
Comment on attachment 112810 [details]
Proposed Change

View in context: https://bugs.webkit.org/attachment.cgi?id=112810&action=review

The patch looks ok, but we have been trying to avoid global state, so I think it would be better for these settings to go on the WKContextRef.

> Source/WebKit2/UIProcess/API/C/mac/WKInspectorMac.h:39
> +WK_EXPORT void WKInspectorSetCustomBasePath(WKStringRef);
> +WK_EXPORT void WKInspectorSetCustomPagePath(WKStringRef);
> +WK_EXPORT void WKInspectorSetCustomLocalizedStringsPath(WKStringRef);

We usually add parameter names in API headers.  These should probably also be per-WKContextRef, not global as they currently are.
Comment 3 Timothy Hatcher 2011-10-28 11:47:36 PDT
Created attachment 112888 [details]
Proposed Change (round 2)
Comment 4 Timothy Hatcher 2011-10-28 13:52:32 PDT
Committed r98759