RESOLVED FIXED 71087
REGRESSION (r98639): NRWT crashes when parsing leaks output 
https://bugs.webkit.org/show_bug.cgi?id=71087
Summary REGRESSION (r98639): NRWT crashes when parsing leaks output
Adam Roben (:aroben)
Reported 2011-10-27 19:04:59 PDT
NRWT is crashing when parsing leaks output. From http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/19794/steps/layout-test/logs/stdio : 2011-10-27 18:40:46,932 95552 stack_utils.py:67 DEBUG File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Tools/Scripts/webkitpy/layout_tests/controllers/worker.py", line 91, in run 2011-10-27 18:40:46,932 95552 stack_utils.py:67 DEBUG self._worker_connection.run_message_loop() 2011-10-27 18:40:46,932 95552 stack_utils.py:67 DEBUG File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Tools/Scripts/webkitpy/layout_tests/controllers/message_broker.py", line 191, in run_message_loop 2011-10-27 18:40:46,932 95552 stack_utils.py:67 DEBUG self._broker.run_message_loop(self._run_topic, self._client, delay_secs) 2011-10-27 18:40:46,932 95552 stack_utils.py:67 DEBUG File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Tools/Scripts/webkitpy/layout_tests/controllers/message_broker.py", line 127, in run_message_loop 2011-10-27 18:40:46,932 95552 stack_utils.py:67 DEBUG self._run_loop(topic_name, client, block=True, delay_secs=delay_secs) 2011-10-27 18:40:46,932 95552 stack_utils.py:67 DEBUG File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Tools/Scripts/webkitpy/layout_tests/controllers/message_broker.py", line 141, in _run_loop 2011-10-27 18:40:46,932 95552 stack_utils.py:67 DEBUG self._dispatch_message(msg, client) 2011-10-27 18:40:46,932 95552 stack_utils.py:67 DEBUG File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Tools/Scripts/webkitpy/layout_tests/controllers/message_broker.py", line 150, in _dispatch_message 2011-10-27 18:40:46,933 95552 stack_utils.py:67 DEBUG message_handler(message.src, *optargs) 2011-10-27 18:40:46,933 95552 stack_utils.py:67 DEBUG File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Tools/Scripts/webkitpy/layout_tests/controllers/worker.py", line 111, in handle_test_list 2011-10-27 18:40:46,933 95552 stack_utils.py:67 DEBUG self._run_test(test_input) 2011-10-27 18:40:46,933 95552 stack_utils.py:67 DEBUG File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Tools/Scripts/webkitpy/layout_tests/controllers/worker.py", line 131, in _run_test 2011-10-27 18:40:46,933 95552 stack_utils.py:67 DEBUG self.clean_up_after_test(test_input, result) 2011-10-27 18:40:46,933 95552 stack_utils.py:67 DEBUG File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Tools/Scripts/webkitpy/layout_tests/controllers/worker.py", line 189, in clean_up_after_test 2011-10-27 18:40:46,933 95552 stack_utils.py:67 DEBUG self.kill_driver() 2011-10-27 18:40:46,933 95552 stack_utils.py:67 DEBUG File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Tools/Scripts/webkitpy/layout_tests/controllers/worker.py", line 159, in kill_driver 2011-10-27 18:40:46,933 95552 stack_utils.py:67 DEBUG self._driver.stop() 2011-10-27 18:40:46,933 95552 stack_utils.py:67 DEBUG File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 628, in stop 2011-10-27 18:40:46,933 95552 stack_utils.py:67 DEBUG self._server_process.stop() 2011-10-27 18:40:46,933 95552 stack_utils.py:67 DEBUG File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Tools/Scripts/webkitpy/layout_tests/port/server_process.py", line 269, in stop 2011-10-27 18:40:46,933 95552 stack_utils.py:67 DEBUG self._port.check_for_leaks(self.name(), self.pid()) 2011-10-27 18:40:46,934 95552 stack_utils.py:67 DEBUG File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Tools/Scripts/webkitpy/layout_tests/port/mac.py", line 131, in check_for_leaks 2011-10-27 18:40:46,934 95552 stack_utils.py:67 DEBUG self._leak_detector.check_for_leaks(process_name, process_pid) 2011-10-27 18:40:46,934 95552 stack_utils.py:67 DEBUG File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py", line 126, in check_for_leaks 2011-10-27 18:40:46,934 95552 stack_utils.py:67 DEBUG _log.debug("Checking for leaks in %s" % process_name)
Attachments
Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-10-27 19:06:00 PDT
2011-10-27 18:40:46,935 95429 manager.py:1409 ERROR worker/0 raised NameError('global name '_log' is not defined'):
Eric Seidel (no email)
Comment 2 2011-10-27 19:47:37 PDT
Sorry. Easy fix. Will post once I'm back home from dinner.
Eric Seidel (no email)
Comment 3 2011-10-27 20:43:51 PDT
Odd. That line didn't change. I guess it broke a while ago.
Eric Seidel (no email)
Comment 4 2011-10-27 20:46:10 PDT
That should fix the problem. I'm very sorry for the redness.
Eric Seidel (no email)
Comment 5 2011-10-27 20:48:14 PDT
http://trac.webkit.org/changeset/98682
Note You need to log in before you can comment on or make changes to this bug.