Rename a couple of NetscapePlugin and PluginProxy member variables
Created attachment 112789 [details] Patch
Comment on attachment 112789 [details] Patch Attachment 112789 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10231568
Committed r98873: <http://trac.webkit.org/changeset/98873>
It broke the GTK build: (as EWS noticed you before landing ...) CXX Source/WebKit2/WebProcess/Plugins/Netscape/x11/Programs_WebKitPluginProcess-NetscapePluginX11.o ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: In member function ‘void WebKit::NetscapePlugin::platformGeometryDidChange()’: ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:216:9: error: ‘m_frameRect’ was not declared in this scope ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:221:57: error: ‘m_frameRect’ was not declared in this scope ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: In member function ‘void WebKit::NetscapePlugin::platformPaint(WebCore::GraphicsContext*, const WebCore::IntRect&, bool)’: ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:262:27: error: ‘m_frameRect’ was not declared in this scope ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: In member function ‘bool WebKit::NetscapePlugin::platformHandleMouseEvent(const WebKit::WebMouseEvent&)’: ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:417:46: error: ‘m_frameRect’ was not declared in this scope ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: In member function ‘bool WebKit::NetscapePlugin::platformHandleWheelEvent(const WebKit::WebWheelEvent&)’: ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:458:57: error: ‘m_frameRect’ was not declared in this scope ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: In member function ‘bool WebKit::NetscapePlugin::platformHandleMouseEnterEvent(const WebKit::WebMouseEvent&)’: ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:485:44: error: ‘m_frameRect’ was not declared in this scope ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: In member function ‘bool WebKit::NetscapePlugin::platformHandleMouseLeaveEvent(const WebKit::WebMouseEvent&)’: ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:497:44: error: ‘m_frameRect’ was not declared in this scope make[1]: *** [Source/WebKit2/WebProcess/Plugins/Netscape/x11/Programs_WebKitPluginProcess-NetscapePluginX11.o] Error 1 make[1]: Leaving directory `/var/lib/buildbot/build/gtk-linux-32-release/build/WebKitBuild/Release' make: *** [all] Error 2 Could you fix the build please?
Sorry, I'll fix it. I had forgotten to save my changes to NetscapePluginX11.cpp
(In reply to comment #5) > Sorry, I'll fix it. I had forgotten to save my changes to NetscapePluginX11.cpp Fix landed in http://trac.webkit.org/changeset/98898