Move type-specific exception descriptions into the implementation files for each type
Created attachment 112782 [details] Patch
Comment on attachment 112782 [details] Patch crazy. Looks fine if EWS says it's fine.
Created attachment 112794 [details] Patch
Comment on attachment 112794 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112794&action=review LGTM. > Source/WebCore/dom/EventException.cpp:54 > + description->typeName = "DOM Events"; > + description->code = ec - EventExceptionOffset; > + description->type = EventExceptionType; So strange that we're passed in a Description, instead of returning one. Then it's constructor could do all this jazz. I guess we could have a fill() function until then.
Created attachment 112796 [details] Patch
Comment on attachment 112796 [details] Patch Attachment 112796 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10223979
It's to match the API of http://trac.webkit.org/browser/trunk/Source/WebCore/dom/ExceptionCode.h#L97
Created attachment 112800 [details] Patch
Created attachment 112803 [details] Patch
Comment on attachment 112803 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112803&action=review Our build system(s) setup is epicly bad. We really need to end this madness. > Source/WebCore/dom/DOMCoreException.cpp:34 > +// FIXME: This should be an array of structs to pair the names and descriptions. Thank you for adding this. > Source/WebCore/dom/DOMCoreException.cpp:104 > + description->typeName = "DOM"; > + description->code = ec; > + description->type = DOMExceptionType; > + > + size_t tableSize = WTF_ARRAY_LENGTH(coreExceptionNames); > + size_t tableIndex = ec - INDEX_SIZE_ERR; > + > + description->name = tableIndex < tableSize ? coreExceptionNames[tableIndex] : 0; > + description->description = tableIndex < tableSize ? coreExceptionDescriptions[tableIndex] : 0; This should be some sort of constructor or "fill" method in a later iteration of this cleanup.
Committed r98686: <http://trac.webkit.org/changeset/98686>