Bug 71078 - [chromium] Track wheel event handler registration and pass to input filter
Summary: [chromium] Track wheel event handler registration and pass to input filter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-27 16:28 PDT by James Robinson
Modified: 2011-10-28 16:30 PDT (History)
7 users (show)

See Also:


Attachments
Patch (12.36 KB, patch)
2011-10-27 16:30 PDT, James Robinson
no flags Details | Formatted Diff | Diff
Patch (12.37 KB, patch)
2011-10-27 17:29 PDT, James Robinson
kbr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2011-10-27 16:28:00 PDT
[chromium] Track wheel event handler registration and pass to input filter
Comment 1 James Robinson 2011-10-27 16:30:38 PDT
Created attachment 112779 [details]
Patch
Comment 2 James Robinson 2011-10-27 16:31:48 PDT
This should make it much easier to test compositor threading things. This patch changes the behavior when --enable-threaded-compositing is passed in, but that's not yet a supported configuration.
Comment 3 Vangelis Kokkevis 2011-10-27 17:21:45 PDT
Comment on attachment 112779 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112779&action=review

Looks good

> Source/WebKit/chromium/src/WebViewImpl.cpp:786
> +    m_haveWheelEventHandlers = numberOfWheelHandlers;

Is this WebKit style?  I would find something like:

m_haveWheelEventHandlers = (numberOfWheelHandlers > 0)

a bit easier to read.
Comment 4 James Robinson 2011-10-27 17:24:41 PDT
WK style is to avoid comparisons to 0 generally, but I agree that it'd be nice to call out the int->bool conversion here.  Will change.
Comment 5 James Robinson 2011-10-27 17:29:08 PDT
Created attachment 112787 [details]
Patch
Comment 6 Kenneth Russell 2011-10-28 10:20:38 PDT
Comment on attachment 112787 [details]
Patch

Looks fine. r=me
Comment 7 James Robinson 2011-10-28 16:30:17 PDT
Committed r98778: <http://trac.webkit.org/changeset/98778>