Bug 71073 - ENH: Add 8 bit string support to JSC JIT
Summary: ENH: Add 8 bit string support to JSC JIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-10-27 16:15 PDT by Michael Saboff
Modified: 2011-10-27 18:10 PDT (History)
1 user (show)

See Also:


Attachments
Proposed patch (13.98 KB, patch)
2011-10-27 16:37 PDT, Michael Saboff
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2011-10-27 16:15:13 PDT
Add support to check string size and access characters appropriately.
Comment 1 Michael Saboff 2011-10-27 16:16:22 PDT
<rdar://problem/10225124> Update JIT to access 8-bit Strings
Comment 2 Michael Saboff 2011-10-27 16:37:09 PDT
Created attachment 112781 [details]
Proposed patch
Comment 3 WebKit Review Bot 2011-10-27 16:40:01 PDT
Attachment 112781 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/assembler/X86Assembler.h:1234:  movzbl_mr is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Michael Saboff 2011-10-27 18:10:11 PDT
Committed r98674: <http://trac.webkit.org/changeset/98674>