after https://bugs.webkit.org/show_bug.cgi?id=70442 lands, we could fix the if-statements in the CCLayerImpl settors to be more consistent with usual webkit style.
https://bugs.webkit.org/show_bug.cgi?id=38829 is going to add another bool that we'll want to plumb through so it might be worth doing that at the same time
Created attachment 115503 [details] Patch discussed with James offline, the extra bool won't be part of this patch
Comment on attachment 115503 [details] Patch R=me. Thanks
Comment on attachment 115503 [details] Patch Rejecting attachment 115503 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: r', u'James Robinson', u'--f..." exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp Hunk #1 FAILED at 241. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'James Robinson', u'--f..." exit_code: 1 Full output: http://queues.webkit.org/results/10505200
Created attachment 115630 [details] updated closer to tip of tree
Comment on attachment 115630 [details] updated closer to tip of tree Clearing flags on attachment: 115630 Committed r100682: <http://trac.webkit.org/changeset/100682>
All reviewed patches have been landed. Closing bug.