RESOLVED FIXED 71051
Make FeatureDefines Identical Across OS X Projects 
https://bugs.webkit.org/show_bug.cgi?id=71051
Summary Make FeatureDefines Identical Across OS X Projects
Joseph Pecoraro
Reported 2011-10-27 12:19:41 PDT
JavaScriptCore / WebKit / WebKit2 had out of date FeatureDefines.xcconfigs. The "truth" was WebCore's, which had: - no stale flags (CSS_REGIONS / CSS_EXCLUSIONS) - correctly named flags (SQL_DATABASE not DATABASE) - and some flags others didn't REQUEST_ANIMATION_FRAME)
Attachments
[PATCH] Make FeatureDefines Identical (16.81 KB, patch)
2011-10-27 12:27 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2011-10-27 12:27:04 PDT
Created attachment 112729 [details] [PATCH] Make FeatureDefines Identical cq- cause I'm still building. I also did change WebCore's to reorder it alphabetically, since SQL_DATABASE was obviously out of place, and I was changing that in all other files.
Joseph Pecoraro
Comment 2 2011-10-27 12:53:56 PDT
I'll open another bug to handle adding missing flags, even if they are disabled, like ENABLE_PLUGIN_PROXY_FOR_VIDEO.
Joseph Pecoraro
Comment 3 2011-10-27 12:54:25 PDT
Comment on attachment 112729 [details] [PATCH] Make FeatureDefines Identical cq? built fine locally
David Kilzer (:ddkilzer)
Comment 4 2011-10-27 13:26:29 PDT
Comment on attachment 112729 [details] [PATCH] Make FeatureDefines Identical r=me
WebKit Review Bot
Comment 5 2011-10-27 15:51:55 PDT
Comment on attachment 112729 [details] [PATCH] Make FeatureDefines Identical Clearing flags on attachment: 112729 Committed r98652: <http://trac.webkit.org/changeset/98652>
WebKit Review Bot
Comment 6 2011-10-27 15:51:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.