Bug 71046 - Overridden clippedOverflowRectForRepaint() still uses IntRects
Summary: Overridden clippedOverflowRectForRepaint() still uses IntRects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-27 11:59 PDT by Simon Fraser (smfr)
Modified: 2011-10-28 14:55 PDT (History)
4 users (show)

See Also:


Attachments
Patch (11.01 KB, patch)
2011-10-28 13:37 PDT, Emil A Eklund
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2011-10-27 11:59:51 PDT
c.f.
IntRect RenderReplaced::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const
and

LayoutRect RenderBox::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const
Comment 1 Simon Fraser (smfr) 2011-10-28 12:51:09 PDT
Was this intentional? It's really confusing to have virtual methods with apparently different signatures.
Comment 2 Emil A Eklund 2011-10-28 13:08:43 PDT
No, it's not intentional. Thanks for pointing it out!

I'll take care of it.
Comment 3 Emil A Eklund 2011-10-28 13:37:40 PDT
Created attachment 112903 [details]
Patch
Comment 4 Simon Fraser (smfr) 2011-10-28 13:40:47 PDT
Comment on attachment 112903 [details]
Patch

Are there other methods that have the same issue?
Comment 5 Emil A Eklund 2011-10-28 13:44:30 PDT
> Are there other methods that have the same issue?

There might be, I'm looking into that now and will make sure to fix any occurrences I can find.

Thanks again for bringing this to my attention.
Comment 6 WebKit Review Bot 2011-10-28 14:55:27 PDT
Comment on attachment 112903 [details]
Patch

Clearing flags on attachment: 112903

Committed r98767: <http://trac.webkit.org/changeset/98767>
Comment 7 WebKit Review Bot 2011-10-28 14:55:32 PDT
All reviewed patches have been landed.  Closing bug.