Bug 71043 - [GTK] Fix leak when fullscreening a video
Summary: [GTK] Fix leak when fullscreening a video
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-27 11:38 PDT by Jonathon Jongsma (jonner)
Modified: 2011-10-27 16:06 PDT (History)
4 users (show)

See Also:


Attachments
leak fix patch (3.75 KB, patch)
2011-10-27 11:38 PDT, Jonathon Jongsma (jonner)
no flags Details | Formatted Diff | Diff
[GStreamer] Prevent memory leak when fullscreening a video https://bugs.webkit.org/show_bug.cgi?id=71043 (4.06 KB, patch)
2011-10-27 12:11 PDT, Jonathon Jongsma (jonner)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathon Jongsma (jonner) 2011-10-27 11:38:40 PDT
Created attachment 112717 [details]
leak fix patch

When fullscreening a video, the dynamic pad name string is leaked.  patch attached to plug the leak.
Comment 1 WebKit Review Bot 2011-10-27 11:45:03 PDT
Attachment 112717 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.h:28:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Jonathon Jongsma (jonner) 2011-10-27 12:11:10 PDT
Created attachment 112725 [details]
[GStreamer] Prevent memory leak when fullscreening a video https://bugs.webkit.org/show_bug.cgi?id=71043

Reviewed by NOBODY (OOPS!).

* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::GStreamerGWorld):
(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):
* platform/graphics/gstreamer/GStreamerGWorld.h:
Comment 3 Gustavo Noronha (kov) 2011-10-27 12:25:41 PDT
Comment on attachment 112725 [details]
[GStreamer] Prevent memory leak when fullscreening a video https://bugs.webkit.org/show_bug.cgi?id=71043

LGTM!
Comment 4 WebKit Review Bot 2011-10-27 16:06:40 PDT
Comment on attachment 112725 [details]
[GStreamer] Prevent memory leak when fullscreening a video https://bugs.webkit.org/show_bug.cgi?id=71043

Clearing flags on attachment: 112725

Committed r98654: <http://trac.webkit.org/changeset/98654>
Comment 5 WebKit Review Bot 2011-10-27 16:06:45 PDT
All reviewed patches have been landed.  Closing bug.