ERROR: test_rebaseline_expectations (webkitpy.tool.commands.rebaseline_unittest.TestRebaseline) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py", line 112, in test_rebaseline_expectations OutputCapture().assert_outputs(self, command.execute, [MockTool(), None, None], expected_stdout=expected_stdout, expected_stderr=expected_stderr) File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/Tools/Scripts/webkitpy/common/system/outputcapture.py", line 74, in assert_outputs return_value = function(*args, **kwargs) File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 201, in execute self._update_expectations_file(port_name) File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 177, in _update_expectations_file expectations = self._expectations(port) File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 171, in _expectations return TestExpectations(port, None, port.test_expectations(), port.test_configuration()) File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py", line 709, in __init__ self._report_errors() File "/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py", line 794, in _report_errors raise ParseError(fatal=True, errors=errors) ParseError: Line:1840 Entries on line 1509 and line 1840 match overlapping sets of configurations fast/backgrounds/size/contain-and-cover.html Line:2248 Entries on line 1526 and line 2248 match overlapping sets of configurations svg/hixie/perf/001.xml Line:2249 Entries on line 1527 and line 2249 match overlapping sets of configurations svg/hixie/perf/002.xml
test_rebaseline_expectations needs to spit out the name of the expectations file that's it's failing with on error.
What patch cause the failure?
I've modified my local version to do this. ParseError: FAILURES FOR <leopard, x86, debug, cpu> in /Users/levin/src/WebKit-misc/LayoutTests/platform/chromium/test_expectations.txt I'm locating the patch that caused this. I'm surprised that the gardener hasn't fixed this. (It seems like it should be killing layout test runs.)
Caused by r98569.
Created attachment 112733 [details] Patch
Isn't this going to conflict with http://trac.webkit.org/changeset/98602? Did you sync to tip of tree?
Comment on attachment 112733 [details] Patch ran into a merge conflict...
Created attachment 112737 [details] Patch
Comment on attachment 112737 [details] Patch Please commit this as soon as possible as opposed to waiting for the cq.
David, can we also make improvements to test_rebaseline_expectations to make the cause more obvious in future?
Created attachment 112742 [details] Patch
(In reply to comment #10) > David, can we also make improvements to test_rebaseline_expectations to make the cause more obvious in future? Working on it. In between lots of other small fires today :(
Created attachment 112746 [details] Patch
this times different overlaps showed up in lint... ? oh well.
Committed r98636: <http://trac.webkit.org/changeset/98636>