Bug 71032 – REGRESSION(r98542): tables/mozilla_expected_failures/bugs/bug14007-2.html

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Ryosuke Niwa]

Chromium bots tells me that r98542 broke tables/mozilla_expected_failures/bugs/bug14007-2.html
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=tables%2Fmozilla_expected_failures%2Fbugs%2Fbug14007-2.html

[Antti Koivisto]

Created attachment 112718 [details]
patch

[Dave Hyatt]

Comment on attachment 112718 [details]
patch

r=me

[Antti Koivisto]

http://trac.webkit.org/changeset/98615

[Antti Koivisto]

Created attachment 112863 [details]
better, more explicit test

[Ryosuke Niwa]

Comment on attachment 112863 [details]
better, more explicit test

View in context: https://bugs.webkit.org/attachment.cgi?id=112863&action=review

> LayoutTests/fast/css/inherited-properties-explicit.html:36
> +These should be 0px, 0px, 5px, 5px, 10px, 10px:

Instead of stating expectations here

> LayoutTests/fast/css/inherited-properties-explicit.html:49
> +test('test1a', 'margin-left');
> +test('test1b', 'margin-left');
> +test('test2a', 'margin-left');
> +test('test2b', 'margin-left');
> +test('test3a', 'margin-left');
> +test('test3b', 'margin-left');

Can we just call shouldBe here? (i.e. turn this into a script test.

[Antti Koivisto]

http://trac.webkit.org/changeset/98800(In reply to comment #5)
> Can we just call shouldBe here? (i.e. turn this into a script test.

Yeah, did this.

http://trac.webkit.org/changeset/98800